Repository navigation
test: area A tests pass on the stage-boundaries branch (types → physical, executor) - #1109
Merged
Merged
Conversation
#1099 rewrote `edge.data_state.timing = phase` as `edge.data_state().timing = phase`, which assigns to a copy: the edges kept QueryTime while the nodes moved to IngestionTime, and bind rejected the DAG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
#1106 (P3c) walks memo groups: structurally equal aggregates and HAVING filters are one group, with one target per (group, measure) and HAVING placed per group; roots are named by workload index, and an inventory matches any DAG built from structurally equal roots. - having_on_one_consumer_of_a_shared_aggregate_stays_above: two equal HAVING filters are one group, so one entry. - memo_cached_rules_preserve_occurrence_specific_having: the two equal aggregates are one target; its HAVING stays above the output because an unfiltered consumer reads the group. - assigned_physical_annotation_asap_input_and_invalid_accuracy_are_rejected: InvalidAccuracy names the root by workload index ("0"); doc comment updated. - population_rejects_an_inventory_from_other_roots: the other roots now differ structurally (the same query text is the same DAG). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
support.rs is also compiled by the private corpus, which does not depend on asap-planner. run_stage1_to_stage3 and selected_dag (asap-planner since #1107) move to planner_support.rs, used only by this crate's test binary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone test phase, area A (part of #1108). Merges into
refactor/stage-boundaries.Why
The branch's constituent PRs were checked only with fmt and clippy. This PR makes the tests of the lower crates pass: types, accuracy, cost, frontends, logical, physical and executor.
What
Five failing tests. None was caused by product code, so no Stage 0–2 code changes.
planner_semijoin_sort_limit_contract_at_both_phasesdata_state(), which returns a copy; now usesdata_state_mut()population_rejects_an_inventory_from_other_rootshaving_on_one_consumer_of_a_shared_aggregate_stays_abovememo_cached_rules_preserve_occurrence_specific_havingassigned_physical_annotation_asap_input_and_invalid_accuracy_are_rejectedInvalidAccuracynames the root by its position in the workload; stale doc fixedPrivate corpus:
crates/frontend-promql/tests/support.rsno longer calls the planner facade.run_stage1_to_stage3andselected_dagmove toplanner_support.rs, which only this crate's tests use. The shared file needs only asap-types, frontend-promql and logical.How
Key code interfaces added / modified
Tests only.
Major algorithm changes
None.
Before / After
Verification
fmt and
clippy --workspace --all-targets -D warningsare clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw