Skip to content

test: area A tests pass on the stage-boundaries branch (types → physical, executor) - #1109

Merged
zzylol merged 3 commits into
refactor/stage-boundariesfrom
test/m1-area-a
Oct 30, 2026
Merged

zzylol merged 3 commits into
refactor/stage-boundariesfrom
test/m1-area-a

Conversation

@zzylol

@zzylol zzylol commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Milestone test phase, area A (part of #1108). Merges into refactor/stage-boundaries.

Why

The branch's constituent PRs were checked only with fmt and clippy. This PR makes the tests of the lower crates pass: types, accuracy, cost, frontends, logical, physical and executor.

What

Five failing tests. None was caused by product code, so no Stage 0–2 code changes.

Test Class Fix
executor planner_semijoin_sort_limit_contract_at_both_phases test bug from #1099 it assigned through data_state(), which returns a copy; now uses data_state_mut()
logical population_rejects_an_inventory_from_other_roots expected after P3c (#1106) its "other roots" are now a structurally different query; equal roots are accepted by design
logical having_on_one_consumer_of_a_shared_aggregate_stays_above expected after P3c identical HAVING filters are one memo group, so there is one entry; the placement check is kept
logical memo_cached_rules_preserve_occurrence_specific_having expected after P3c now asserts one target, placed above the aggregate because an unfiltered consumer reads the group
logical assigned_physical_annotation_asap_input_and_invalid_accuracy_are_rejected expected after P3c InvalidAccuracy names the root by its position in the workload; stale doc fixed

Private corpus: crates/frontend-promql/tests/support.rs no longer calls the planner facade. run_stage1_to_stage3 and selected_dag move to planner_support.rs, which only this crate's tests use. The shared file needs only asap-types, frontend-promql and logical.

How

  • Each failure was rerun alone.
  • Each was classified as a stale expectation from an intended change, a deleted feature, or a regression.
  • Expectations were updated only where an intended change explains the difference.

Key code interfaces added / modified

Tests only.

Major algorithm changes

None.

Before / After

  • Before: 5 failures across the logical crate and the executor.
  • After: all area-A crates pass.

Verification

fmt and clippy --workspace --all-targets -D warnings are clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw

zzylol and others added 3 commits October 30, 2026 17:07
#1099 rewrote `edge.data_state.timing = phase` as `edge.data_state().timing = phase`,
which assigns to a copy: the edges kept QueryTime while the nodes moved to
IngestionTime, and bind rejected the DAG.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
#1106 (P3c) walks memo groups: structurally equal aggregates and HAVING
filters are one group, with one target per (group, measure) and HAVING
placed per group; roots are named by workload index, and an inventory
matches any DAG built from structurally equal roots.

- having_on_one_consumer_of_a_shared_aggregate_stays_above: two equal
  HAVING filters are one group, so one entry.
- memo_cached_rules_preserve_occurrence_specific_having: the two equal
  aggregates are one target; its HAVING stays above the output because
  an unfiltered consumer reads the group.
- assigned_physical_annotation_asap_input_and_invalid_accuracy_are_rejected:
  InvalidAccuracy names the root by workload index ("0"); doc comment updated.
- population_rejects_an_inventory_from_other_roots: the other roots now
  differ structurally (the same query text is the same DAG).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
support.rs is also compiled by the private corpus, which does not depend
on asap-planner. run_stage1_to_stage3 and selected_dag (asap-planner since
#1107) move to planner_support.rs, used only by this crate's test binary.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor testing Corpus, regression, differential, or benchmark tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant