Repository navigation
test: area B tests pass on the stage-boundaries branch; fix decoded-output validation (plan-selection, planner) - #1110
Merged
Conversation
P7 (#1107) made validate_selected_graph check the selection through to_selected_candidates, which sorts the roots by output index and drops the index. A root assigned to a nonexistent output (or two roots to one output) then passed validation. Check that the assigned output indices are exactly 0..n before converting, as the checker did before P7. decoded_graph_is_checked_independently_of_solver_values covers it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
…sults P7 (#1107) moved the query-time-results-retained capability from the planning models into the Stage 2 realizer. The two kept-pane pricing tests still set it only on their deployment, so the test realizer refused MatAtQueryKeptAcrossEvaluations(Memory). Build the realizer with the deployment's flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
…ot an infeasibility label Both tests asserted the infeasible_under_configured_model status and the early pruning's rejection text. P6b (#1105) deleted early query pruning, which proved these catalogs infeasible, and P7 (#1107) removed that status from Stage 3's report: today's engine now stops at its budget with no validated plan. The tests now assert that plan selection selected none (no valid candidate, or none by the deadline); the ignore-accuracy test's selected sketch plan is still checked end to end. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
This was referenced Oct 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone test phase, area B (part of #1108). Merges into
refactor/stage-boundaries.Why
The branch's constituent PRs were checked only with fmt and clippy. This PR makes the asap-plan-selection and asap-planner tests pass, and fixes one regression that P7 introduced.
What
Regression fixed (
fix(plan-selection): decoded selections assign each query output once):validate_selected_graphcheckselected.to_selected_candidates().0..nbefore converting. Test:decoded_graph_is_checked_independently_of_solver_values.Stale expectations from intended changes:
kept_pane_profiles_and_scan_classes_match_the_real_evaluator,shared_pane_range_tiers_match_evaluator_for_ingestion_and_kept_refreshan_undeclared_gauges_merged_ddsketch_panes_get_no_relative_bound_through_avg,ignoring_accuracy_guarantees_selects_a_sketch_plan_that_runs(its "without the setting" half)Coverage lost: the undeclared-gauge test no longer checks why there is no plan. Today's engine reports
NoValidCandidatewith no rejections for this workload. #1095's region DP reports pruned candidates with reasons; that is noted on #1095.How
Key code interfaces added / modified
None (one private validation check).
Major algorithm changes
None.
Before / After
Verification
reference-pricer)plan_selection_settings_jsontests/mainfmt and
clippy --workspace --all-targets -D warningsare clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw