Skip to content

test: area C tests on the stage-boundaries branch; reference enumeration applies Stage 2's raw-data rule - #1111

Merged
zzylol merged 3 commits into
refactor/stage-boundariesfrom
test/m1-area-c
Oct 30, 2026
Merged

zzylol merged 3 commits into
refactor/stage-boundariesfrom
test/m1-area-c

Conversation

@zzylol

@zzylol zzylol commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Milestone test phase, area C (part of #1108). Merges into refactor/stage-boundaries.

Why

The branch's constituent PRs were checked only with fmt and clippy. This PR fixes the integration tests, the devtools tests and the DAG viewer tests, plus one regression in the devtools reference path.

What

Regression fixed: fix(devtools): the reference enumeration drops plans that scan raw data the deployment doesn't keep.

Stale expectations from intended changes (details in the commit messages):

Still failing (fixed in a follow-up PR on the branch):

  1. With a zero budget, Pass 1's deadline error is reported instead of DeadlineReached. The cause is the error mapping in planner/src/run.rs. Fails zero_budget_returns_no_unvalidated_plan and milp_time_limit_is_reported.
  2. With guarantees enforced, the ratio of quantiles gets no plan (a P3c regression). Fails ratio_of_quantiles_no_listed_choice_is_cheaper_than_the_selected_plan and workload_examples_preserve_data_and_valid_materialized_views.

How

  • Each failure was rerun alone.
  • Each was classified as a stale expectation, a deleted feature, or a regression.
  • Regressions are fixed in code, not in the test.

Key code interfaces added / modified

asap_devtools::memo_pricing::retain_deployable.

Major algorithm changes

None.

Before / After

Binary Result
integration 361 passed, 1 failing (item 1 above), 24 ignored
devtools tests 76 passed, 3 failing (items 1 and 2 above)
devtools lib 17
planner_fuzz 4
corpus_snapshots, non-ignored 7
DAG viewer JS 41
test_viewer + test_server 116

Verification

fmt and clippy --workspace --all-targets -D warnings are clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw

zzylol and others added 3 commits October 30, 2026 17:43
…ta a deployment does not keep

#1047 P6 moved the raw-data rule from Stage 3's checks into Stage 2's
catalog (PruneReason::RawDataNotRetained). The devtools reference path
implements Stage 2 with optimize_physical_asap, which enumerates every
assignment, so stage_pipeline --exhaustive, --price-enumerated and the
integration tests' explicit fixtures priced query-time raw scans that the
deployment cannot run, and selected them. memo_pricing::retain_deployable
applies Stage 2's rule; physical_plans_of and run_explicit_candidates use it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
#1047 P7 made stage3_plan_selection Stage 3's Selection (the plan P1 with
its cost, accepted_accuracy_per_query and search_report) and moved the
per-candidate table under --exhaustive to reference_pricing; the facade's
PlanningReport is planning_report. The stage_pipeline, memo_pricing and
viewer tests, and server.py's log line, read that shape; a Pass 1 failure's
Stage 3 section is a Selection without a plan. Deleted: the Pareto-front
check (ClusterObjective::ParetoFront is gone) and the component and
candidates-checked report fields (the engine has no components).
viewer_contract reads a JS array up to its own ']'.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
…planning budget

- Pass 1 now composes a candidate from memo groups (P3c), so queries that
  read an identical input share its node. The Example 1 and 3 fixtures
  build their independent variant with planner_layering_common::unshare,
  and materialization_e2e splits a node read at two timings
  (split_shared_by_timing) as Stage 2 does.
- memo_enumeration: one target per quantile group (3 x 3 inventory
  assignments, P3c); a 90 s budget, since Stage 3 searches until the
  deadline when it validates no plan.
- finer_aggregate_reuse::filtered_kll_states_cost_no_more_than_separate_plans
  is ignored until #1095: P7 removed the per-query seed that reached the
  separate plans' cost.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-tools Developer tools, diagnostics, and demos testing Corpus, regression, differential, or benchmark tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant