Repository navigation
fix: lower_metricsql and lower_metricsql_query stay public (CI external-consumer check) - #1114
Merged
Merged
Conversation
…ay public API tools/verify_metricsql_external_consumer.sh (CI) treats them as a stable external dependency; #1099 had moved them behind test-support. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1108's CI fix. Merges into
refactor/stage-boundaries.Why
#1108's
testjob failed at "Verify MetricsQL frontend as a stable external dependency" (tools/verify_metricsql_external_consumer.sh). That step builds an outside crate that callsasap_frontend_metricsql::lower_metricsql. #1099 (8b part 2) had movedlower_metricsqlandlower_metricsql_querybehindtest-support, because no in-repo production code calls them. But CI declares them stable public API.What
lower_metricsqlandlower_metricsql_queryare public at the crate root again.test_supportre-exports them, so the existing test paths keep compiling. The private corpus'sjane_street_corpus.rsuseslower_metricsql_query, so it no longer needs thetest-supportchange that was planned for it.How
The two functions move from
test_support.rsintolib.rsunchanged.Key code interfaces added / modified
pub fn asap_frontend_metricsql::{lower_metricsql, lower_metricsql_query}(restored).Usage:
asap_frontend_metricsql::lower_metricsql("sum(rate(requests_total[5m]))", AccuracyTarget::exact(), Duration::from_secs(15))from a downstream crate.Major algorithm changes
None.
Before / After
lower_metricsql".Verification
bash tools/verify_metricsql_external_consumer.shpasses.cargo test -p asap-frontend-metricsql: 15 passed.clippy --workspace --all-targets -D warningsare clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw