Repository navigation
test: sketch-execution tests plan with guarantees ignored after Pass 1's accuracy pruning - #1118
Merged
Merged
Conversation
…ng guarantees #1116 makes Pass 1 prune a summary no reading query can use for its accuracy target when guarantees are enforced. Seven integration tests read the reference enumeration under the built-in strict model to check the structure or execution of a summary whose output Stage 3 already rejected at that target before #1116: a heap-backed Top-K and a value filter or group key over an estimate have no guarantee, and a grouped KLL quantile's per-value guarantee meets no whole-result target over groups the data does not bound. Pass 1 now prunes those summaries, so the tests found no candidate. The tests now plan with every output accepted (logical_candidates_ignoring_guarantees, ignore_accuracy_guarantees), as they check rewrites and execution, not accuracy acceptance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1108's CI fix. Merges into
refactor/stage-boundaries.Why
After #1116, CI's
integrationbinary failed 7 tests. Pass 1 now prunes summaries that no reading query can use for its accuracy target. These tests relied on such summaries.What
All 7 are stale expectations; #1116 has no over-pruning bug.
bd46e688call 7 fail.filtered_aggregates::hand_filtered_kll_compiles_and_executes,kll_quantile_of_all_null_group_is_nullper_computation_candidates_sql::a_filter_or_group_key_over_an_estimate_has_no_guaranteepromql_to_post_asap::planner_heap_topk_reference_execution_matches_ground_truth,planner_only_e2e_temporal_topk_preserves_query_update_and_evaluation_contractsql_to_post_asap::sql_filter_keeps_read_predicate_and_summary_population_selection,sql_relational_parents_retain_summary_bound_aggregateThese tests check compilation and execution of sketch plans, not accuracy. They now plan with guarantees ignored, through a new helper,
planning::logical_candidates_ignoring_guarantees. The original helpers keep the accuracy check for every other test.How
The bisection and Stage 3's rejection reasons are recorded above. No assertions were weakened, and no
#[ignore]was added.Key code interfaces added / modified
asap_integration_tests::planning::logical_candidates_ignoring_guarantees(test support).Major algorithm changes
None.
Before / After
integrationhad 355 passed and 7 failed.Verification
cargo test -p asap-integration-tests --test integrationpasses: 362 passed, 0 failed, 24 ignored.clippy --workspace --all-targets -D warningsare clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01K1M6bqhAk7WA4MZcfbAoMw