Repository navigation
test: run an out-of-tree MetricsQL corpus from $ASAP_EXTERNAL_CORPUS_DIR - #1162
Merged
Merged
Conversation
Moves the private corpus's test runner into public so it compiles with public's own dev-dependencies on every PR. A change to the shared support.rs now fails its own PR instead of the private nightly. The test skips when the env var is unset; floors come from a `# floor: N` line in each corpus file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
milindsrivastava1997
force-pushed
the
test/external-corpus
branch
from
November 2, 2026 22:49
81fdc32 to
d56a399
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The private corpus (ASAPPlanner-private-corpus)
#[path]-includedcrates/frontend-promql/tests/support.rsand kept its ownCargo.tomldependency list. Wheneversupport.rsstarted importing a new crate or feature-gated module, public CI stayed green and the private nightly broke the next morning. That happened twice in a week:asap-typestest-support (private #4/#5), thenlogical-asap-optimization::test_supportafter #1108.What
Moves the test runner into public; the private repo keeps only the queries.
crates/frontend-metricsql/tests/external_corpus.rs: lowers and binds every query in every*.txtunder$ASAP_EXTERNAL_CORPUS_DIR, checks that nothing panics, nothing that lowers fails to bind, and each file's lowered count stays at or above its# floor: Nline. Prints failure causes by count. Skips when the env var is unset, so CI compiles it on every PR but needs no data.support.rs(forlogical_plan) via#[path]in themetricsqltest binary, and addsasap-logical-asap-optimization(test-support) as a dev-dependency. A futuresupport.rsimport change now fails here, in the PR that makes it.Run locally:
Testing
clippy --all-targets --all-features -D warnings: clean.Companion PR in ASAPPlanner-private-corpus (
chore/data-only); merge this one first, since that repo's CI runs against publicmain.Note: the pre-commit
cargo testfailed once on twoasap-devtoolsstage_pipelinetests ("MILP solver: execution-scope expansion exceeded the deadline"). They're timing-sensitive under full-suite load and pass in isolation; they're unrelated to this change.🤖 Generated with Claude Code