Repository navigation
fix(frontend-metricsql): pass a HistogramCatalog in the vector-negation test - #1172
Closed
milindsrivastava1997 wants to merge 1 commit into
Closed
milindsrivastava1997 wants to merge 1 commit into
milindsrivastava1997 wants to merge 1 commit into
Conversation
Contributor
|
@milindsrivastava1997 HistogramCatalog will be deleted in #1174 |
Collaborator
Author
|
Superseded: #1174 removed the HistogramCatalog parameter, so main builds the metricsql tests again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maindoesn't compile themetricsqltest binary: #1120 added a one-argumentlower_promql_query_workloadcall inlowering_semantics.rs, and #1121 added the function's&HistogramCatalogparameter. Each passed CI alone; everymainRust CI run since #1121 fails atlowering_semantics.rs:160(E0061).Passes
&HistogramCatalog::default(), as the other callers do.Tested:
cargo fmt --check, workspaceclippy --all-targets --all-features -D warnings,cargo test -p asap-frontend-metricsql --test metricsql(16 passed).🤖 Generated with Claude Code