Repository navigation
chore: sync agent standards: review-first PR descriptions and diff-block interfaces - #1257
Merged
Merged
Conversation
…ock interfaces Copies asap-pr-authoring (skill and example), the PR template and AGENTS.md from agent-standards 5fca789. Keeps this repository's snapshot-changes rule, now pointing at the Verification section.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repository's PR-description skill and template lag agent-standards by two changes: interfaces as
diffblocks (agent-standards #12) and the review-first section list (agent-standards #14). This PR copies them from agent-standards5fca789. Example: the #1207 stack's PR bodies (#1224, #1226–#1239) already use the new sections, which the in-repo skill does not describe yet.Review guide
main..agents/skills/asap-pr-authoring/and.github/PULL_REQUEST_TEMPLATE/projectasap.mdare verbatim copies; review them in agent-standards There seem to be 2 ways to express a GROUP BY + Aggregate #12 and test: added tests for PromQL to match queries to L3 IR #14.AGENTS.mdis the agent-standards copy plus one repository-specific line kept frommain: the snapshot-changes rule, now pointing at Verification instead of the removed Snapshot changes heading. The copy also brings three upstream rules this repository had not synced yet (worktrees under.worktrees/, no broadgit add -A, no amending unless asked) and fixes "working DAG" → "working tree".Behavior: before → after
// new,// was X,// removeddiffblocks:+added,-removed, changed as-old then+newInterfaces
None (agent and contributor documentation only).
Algorithm changes
None.
Decisions and open questions
diffinterface blocks (agent-standards There seem to be 2 ways to express a GROUP BY + Aggregate #12, test: added tests for PromQL to match queries to L3 IR #14); a manual sync because the distribution workflow cannot push to this repository yet.Verification
5fca789, except the kept snapshot-changes line inAGENTS.mdFollow-ups
AGENTS.md; the snapshot-changes line should then move to a repository-specific file or into agent-standards.