Skip to content

chore: sync agent standards: review-first PR descriptions and diff-block interfaces - #1257

Merged
zzylol merged 1 commit into
mainfrom
chore/sync-agent-standards-review-first
Nov 10, 2026
Merged

zzylol merged 1 commit into
mainfrom
chore/sync-agent-standards-review-first

Conversation

@zzylol

@zzylol zzylol commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Summary

This repository's PR-description skill and template lag agent-standards by two changes: interfaces as diff blocks (agent-standards #12) and the review-first section list (agent-standards #14). This PR copies them from agent-standards 5fca789. Example: the #1207 stack's PR bodies (#1224, #1226–#1239) already use the new sections, which the in-repo skill does not describe yet.

Review guide

  • Base main.
  • .agents/skills/asap-pr-authoring/ and .github/PULL_REQUEST_TEMPLATE/projectasap.md are verbatim copies; review them in agent-standards There seem to be 2 ways to express a GROUP BY + Aggregate #12 and test: added tests for PromQL to match queries to L3 IR #14.
  • AGENTS.md is the agent-standards copy plus one repository-specific line kept from main: the snapshot-changes rule, now pointing at Verification instead of the removed Snapshot changes heading. The copy also brings three upstream rules this repository had not synced yet (worktrees under .worktrees/, no broad git add -A, no amending unless asked) and fixes "working DAG" → "working tree".

Behavior: before → after

Before After
Why / What / How / Key code interfaces / Major algorithm changes / Before / After / Verification Summary / Review guide / Behavior: before → after / Interfaces / Algorithm changes / Decisions and open questions / Verification / Follow-ups
Interface changes marked by trailing // new, // was X, // removed diff blocks: + added, - removed, changed as - old then + new

Interfaces

None (agent and contributor documentation only).

Algorithm changes

None.

Decisions and open questions

Verification

Scope Passed / failed / ignored Newly failing vs base Notes
Documentation only n/a n/a Files compared byte for byte with agent-standards 5fca789, except the kept snapshot-changes line in AGENTS.md

Follow-ups

  • The next automated distribution overwrites AGENTS.md; the snapshot-changes line should then move to a repository-specific file or into agent-standards.

…ock interfaces

Copies asap-pr-authoring (skill and example), the PR template and AGENTS.md from agent-standards 5fca789. Keeps this repository's snapshot-changes rule, now pointing at the Verification section.
@zzylol zzylol added the documentation Improvements or additions to documentation label Nov 10, 2026
@zzylol
zzylol merged commit 21e2207 into main Nov 10, 2026
1 check passed
@zzylol
zzylol deleted the chore/sync-agent-standards-review-first branch November 10, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant