Repository navigation
refactor(types): name the memo's view-coverage file for what it holds, drop two coverage forwarders, fix stale coverage docs (#1207) - #1272
Merged
Conversation
…, drop two coverage forwarders, fix stale coverage docs (#1207) - Rename stages/logical/aggregate_coverage.rs to view_coverage.rs; the public path stages::view_coverage is unchanged. - Merge coverage_of into Operator::aggregate_coverage and call OperatorInput::reference directly instead of the reference_of forwarder. - Import MemoGroupAsInput from the group module everywhere; drop the private re-export in stages/logical/mod.rs. - Docs: "summary coverage" -> "aggregate coverage" in input.rs; asap-primitive-schema.md no longer describes OperatorNode::coverage() or a CoverageCache, names view_coverage.rs, and says SummaryTypeCannotRegroup. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup after #1207 PR 2 (#1230). The memo file that holds only
view_coveragewas namedaggregate_coverage.rs, two IR functions only forwarded to another, and the design doc still describedOperatorNode::coverage()with aCoverageCache, which no longer exist. This PR renames the file, deletes the forwarders, and fixes the stale text. No behavior change: the same 235 tests pass before and after.Review guide
main(69fc34a); not stacked.MemoGroupAsInputimports,input.rsdoc.Operator::aggregate_coverageinir/properties/aggregate_coverage.rs(the body ofcoverage_ofmoved into the method,operator→self), and §5/§6.1/§6.6 ofasap-primitive-schema.md.Behavior: before → after
None. Plans and outputs are unchanged.
Interfaces
Public paths are unchanged (
asap_types::stages::view_coverage,Operator::aggregate_coverage). Internal changes only:Both removed functions only forwarded (
coverage_ofwas called only by the method;reference_ofonly calledinput.reference(), nowOperatorInput::referenceat its two call sites).Algorithm changes
None.
Decisions and open questions
None.
Verification
cargo test --all-features -p asap-types -p asap-stage0-memo -p asap-stage1-pass1-per-computation-candidates -p asap-stage1-pass2-reuse-candidatesorigin/main69fc34acargo check --workspace --all-features --testscargo clippy --workspace --all-features --all-targets -- -D warningscargo fmt --all --checkNo new tests: moves, renames, and docs only.
Follow-ups
None. The user guide's "Check summary coverage" and planner_fuzz's
campaign_writes_summary_coverage_and_draftsmean something else and are left as they are.Human review — do not complete with an agent