Repository navigation
test(planner): close the histogram_quantile test the #913 merge left open - #916
Merged
Merged
Conversation
zzylol
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
crates/planner/tests/runtime_install.rsdoes not compile on main ("this file contains an unclosed delimiter"), so none of its tests run. The merge of #913 dropped the closing brace ofa_classic_histogram_quantile_keeps_labels_and_handles_inf_and_empty_input, which #910 added, and theabsent()tests ended up inside it.What
The missing
}is restored. Nothing else changes.How
The test's body matches its version in #910 (d865b8f); only the brace was lost.
Key code interfaces added / modified
None.
Major algorithm changes
None.
Before this PR
cargo test -p asap-planner --test runtime_installfails to compile.After this PR
It compiles. The histogram_quantile and absent() tests pass.
Verification
rustfmt --checkon the file is clean.cargo test -p asap-planner --test runtime_install -- histogram absent: 4 passed.