Repository navigation
Remove the old CSG path and the BurstTriangulator dependency - #58
Merged
Merged
Conversation
The exact CSG has been the default for a while; the float CSG that made polygon loops was only reachable through an internal switch. - Removed the loop CSG (PerformCSGJob, the intersection loop, merge and loop vertex cache jobs), the loop triangulation and repair in GenerateSurfaceTrianglesJob, the kExactCSG switch, the propagation rounds, interned planes and the float brush intersection test. - GenerateSurfaceTrianglesJob is Burst compiled itself. - BurstTriangulator was only used by the loop triangulation: the submodule and its reference are gone. - Tests that compared the two paths, or only covered the old one, are gone; the concrete pad area checks now run. Fixes RadicalCSG#57
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exact CSG has been the default for a while; the float CSG that made polygon loops was only reachable through an internal switch.
PerformCSGJob, the intersection loop, merge and loop vertex cache jobs), the loop triangulation and repair inGenerateSurfaceTrianglesJob, thekExactCSGswitch, the propagation rounds, interned planes and the float brush intersection test.GenerateSurfaceTrianglesJobis Burst compiled itself.Checked: full suite 2004 of 2004. Three imported maps (266 models) rebuild to the same triangles as main, model for model, with no errors or warnings.
Fixes #57