Skip to content

fix: Restore auto-close behavior for all flyouts - #10636

Merged
gonfunko merged 2 commits into
RaspberryPiFoundation:mainfrom
mit-cml:fix/flyout-autoclose
Oct 27, 2026
Merged

gonfunko merged 2 commits into
RaspberryPiFoundation:mainfrom
mit-cml:fix/flyout-autoclose

Conversation

@mjgallag

Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #10635

Proposed Changes

Replace the toolbox/workspace flyout if/else with targetWorkspace.hideComponents(false) so other registered components can close their flyouts too.

Reason for Changes

#9610 removed the block-creation call to hideChaff(), which called hideComponents(false). This restores that same call through focus handling, extending #10506 to trashcan, backpack, and custom flyouts such as App Inventor parameter flydowns.

Test Coverage

  • Flyout
    • focus management
      • toolbox
        • Losing flyout focus hides autoclosing flyout and clears category
        • Losing flyout focus preserves non-autoclosing flyout and category
      • workspace
        • Losing focus hides autoclosing flyout
        • Losing focus does not hide non-autoclosing flyout
      • other
        • Losing focus hides autoclosing flyout
        • Losing focus does not hide non-autoclosing flyout

The other tests represent flyouts such as trashcan, backpack, and custom flyouts, including App Inventor parameter flydowns.

@mjgallag
mjgallag requested a review from a team as a code owner October 27, 2026 18:36
@mjgallag
mjgallag requested a review from gonfunko October 27, 2026 18:36
@github-actions github-actions Bot added the PR: fix Fixes a bug label Oct 27, 2026
@gonfunko

Copy link
Copy Markdown
Contributor

Thanks for reporting and fixing this!

@gonfunko
gonfunko merged commit 86f1a6b into RaspberryPiFoundation:main Oct 27, 2026
11 checks passed
mjgallag added a commit to mjgallag/appinventor-sources that referenced this pull request Oct 27, 2026
@mjgallag
mjgallag deleted the fix/flyout-autoclose branch October 27, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trashcan flyout stays open after dragging a block out

2 participants