Repository navigation
fix: Restore auto-close behavior for all flyouts - #10636
Merged
gonfunko merged 2 commits intoOct 27, 2026
Merged
Conversation
gonfunko
approved these changes
Oct 27, 2026
Contributor
|
Thanks for reporting and fixing this! |
mjgallag
added a commit
to mjgallag/appinventor-sources
that referenced
this pull request
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10635
Proposed Changes
Replace the toolbox/workspace flyout
if/elsewithtargetWorkspace.hideComponents(false)so other registered components can close their flyouts too.Reason for Changes
#9610 removed the block-creation call to
hideChaff(), which calledhideComponents(false). This restores that same call through focus handling, extending #10506 to trashcan, backpack, and custom flyouts such as App Inventor parameter flydowns.Test Coverage
The
othertests represent flyouts such as trashcan, backpack, and custom flyouts, including App Inventor parameter flydowns.