Skip to content

Use %chin% subsetting instead of setdiff(intersect()) for j/by col detection #7913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-muecke wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −4
Open

Use %chin% subsetting instead of setdiff(intersect()) for j/by col detection #7913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e4476c
Use %chin% subsetting instead of setdiff(intersect()) for j/by col de…
m-muecke Oct 9, 2026
2ddfa74
Merge branch 'master' into intersect-chin
m-muecke Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions R/data.table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,8 +1218,10 @@ replace_dot_alias = function(e) {
if (any(c("eval","evalq","eval.parent","local","get","mget","dynGet") %chin% all.names(bysub)))
# when the 'by' expression includes get/mget/eval, all.vars cannot be trusted to infer all used columns, #4981
allbyvars = NULL
else
allbyvars = intersect(all.vars(bysub), names_x)
else {
allbyvars = all.vars(bysub)
allbyvars = allbyvars[allbyvars %chin% names_x]
}

orderedirows = .Call(CisOrderedSubset, irows, nrow(x)) # TRUE when irows is NULL (i.e. no i clause). Similar but better than is.sorted(f__)
bysameorder = byindex = FALSE
Expand Down Expand Up @@ -1468,7 +1470,7 @@ replace_dot_alias = function(e) {
}
# fix for long standing FR/bug, #495 and #484
allcols = c(names_x, xdotprefix, names_i, idotprefix)
non_sdvars = setdiff(intersect(av, allcols), c(bynames, ansvars))
non_sdvars = av[av %chin% allcols & !av %chin% c(bynames, ansvars)]

# added 'mget' - fix for #994
if (any(c("get", "mget") %chin% av)){
Expand Down Expand Up @@ -1504,7 +1506,7 @@ replace_dot_alias = function(e) {
} else {
if (!missing(.SDcols)) warningf("This j doesn't use .SD but .SDcols has been supplied. Ignoring .SDcols. See ?data.table.")
allcols = c(names_x, xdotprefix, names_i, idotprefix)
ansvars = sdvars = setdiff(intersect(av, allcols), bynames)
ansvars = sdvars = av[av %chin% allcols & !av %chin% bynames]
if (verbose) catf("Detected that j uses these columns: %s\n",if (!length(ansvars)) "<none>" else brackify(ansvars))
# using a few named columns will be faster
# Consider: DT[,max(diff(date)),by=list(month=month(date))]
Expand Down
Loading