Repository navigation
feat(ledger): record_deconsolidation on the facade - #283
Merged
Merged
Conversation
The generated-tier regens carried the operation; the LedgerClient facade did not. Added beside record_acquisition and record_ownership_change, with its test. The calendar and entity reads already return the generated models, which carry is_former and the unmapped-account fields. Claude-Session: https://claude.ai/code/session_015PxYaVzrbraKFeRALM7rXp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The facade catches up with three generated-tier regens.
LedgerClient.record_deconsolidation(graph_id, *, entity_id, consideration, basis)besiderecord_acquisitionandrecord_ownership_change. The calendar and entity reads already return the generated models, which carryis_formerand the unmapped-account fields.A client minor: additive facade surface. The deconsolidation operation is live on the API since v1.20.0's successor carries rs #1926;
is_formerlikewise; the unmapped-account fields wait on rs #1932. roboledger-app's group-lifecycle work builds on this.Testing
just test-all: 732 passed, 17 skipped; ruff, format and basedpyright clean.🤖 Generated with Claude Code
https://claude.ai/code/session_015PxYaVzrbraKFeRALM7rXp