Repository navigation
vinca: render the skip-existing check as native builds (vinca#192) - #200
Merged
Merged
Conversation
vinca#184 compares exact build strings, rendered without --build-platform: on the linux-64 runner generating the build branches every other platform rendered as a cross build, so its hashes never matched the published packages and about half of each distribution was rebuilt on linux-aarch64, osx and win. Also brings vinca#185, #187, #188 (python dependency handling). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps vinca to 4ff3e37 for RoboStack/vinca#192: the skip-existing check renders the recipes as native builds (
--build-platform= target platform).Since the vinca update in #144, vinca compares exact build strings (vinca#184), but rendered them on the machine generating the recipes. The linux-64 runner that generates the build branches rendered every other platform as a cross build, whose hashes never match the published (natively built) packages. So about half of each distribution's recipes, low-level ones included, were rebuilt on linux-aarch64, osx-64, osx-arm64 and win-64 (humble linux-aarch64: 1218 recipes). Those build-branch runs were cancelled.
Also brings vinca#185, #187 and #188 (python dependency handling).
Checked locally, generating on osx-arm64:
rclpy/rclcppthere only as py314), so those are genuinely missing.CI:
build:none. After merging, the build branches should build only what's missing (mostly lyrical's py312 builds off linux-64).🤖 Generated with Claude Code