Repository navigation
Conversation
|
Hey @Siddh2024! 👋 Tested your branch locally, noticed a few issues worth addressing:
|
|
@swarnendusahu10-dotcom Thanks for the great feedback and for testing it locally! 🙌 I've addressed all 4 points in the latest commits:
All lint and build checks are passing. Please take another look when you get a chance! |
|
@swarnendusahu10-dotcom , we good to merge ? ... also i have found out that the keyboard navigation is not working appropriately on the simple tab ... (Ready to chat tab) ... there .. I found that clicking down the tab then enter ... opens the login module ,,, rather than the tab navigations working |
|
@Aryan-Verma-999 , hey sir ,,, could you please inspect this PR too . |
|
@Siddh2024 Other maintainers will look into your PR in their respective time , its not polite to pin them every time . They will look into your PR and address accordingly . |
fix(react): improve form accessibility and input labeling
Acceptance Criteria fulfillment
id,name, and descriptivearia-label="Upload file"to the hidden file input inChatInput.js.LoginForm.jsfrom<div>tags to semantic<label htmlFor="...">elements with correspondingidandnameattributes.LoginForm.jskeyboard handling by replacing deprecatedonKeyPresswithonKeyDown.<Box is="button" ...>with dynamicaria-label.name,id,autoComplete="one-time-code", accessible label, and Enter-key submission toTwoFactorTotpModal.js.name,id, and descriptivearia-labelattributes to inputs inInsertLinkToolBox.jsandMessageReportWindow.js.@embeddedchat/reactversion tracking.yarn lint) and clean production build (yarn build).Fixes #1441
Video/Screenshots
Before (Browser Audit Warning):
After (Warning Resolved):
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1442 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.