Skip to content

fix(auth): surface secure cookie failures during login and logout - #1449

Merged
Aryan-Verma-999 merged 1 commit into
RocketChat:developfrom
Aryan-Verma-999:fix/secure-cookie-session
Nov 22, 2026
Merged

Aryan-Verma-999 merged 1 commit into
RocketChat:developfrom
Aryan-Verma-999:fix/secure-cookie-session

Conversation

@Aryan-Verma-999

Copy link
Copy Markdown
Collaborator

Handle secure cookie failures during login and logout

EmbeddedChat could report a successful login even when the /auth-token request failed to save the session cookie. The failure only became apparent after a reload, when the user had to sign in again.

Acceptance Criteria fulfillment

  • Wait for the session cookie to be saved before marking the user as signed in. Treat an absent cookie as a signed-out session and propagate request failures to the caller.
  • Prevent a delayed login or session refresh from signing the user back in after logout.
  • Clear local authentication state when logout fails, show an error, and retry any unconfirmed server revocation on the next logout call from the same instance.

Fixes #1141

PR Test Details

After approval, the Storybook preview will be available for live testing.

@Aryan-Verma-999
Aryan-Verma-999 merged commit b87c70c into RocketChat:develop Nov 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Secure token request helper swallows API errors and hides auth/cookie failures

1 participant