Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ui-elements): add visible focus to Button and Menu, and trap focus in Modal
Acceptance Criteria fulfillment
:focus-visibleoutline toButton.styles.jsusingtheme.colors.ringwith a standard 2px offset.Modal.jsusingTabandShift+Tabboundary cycling.Modal.jsto return keyboard focus to the triggering element upon dialog closure.:focusand:focus-visiblehighlights to dropdown menu items inMenu.styles.jsmatching hover state.Escapekey listener inMenu.jsto dismiss the desktop dropdown and restore focus back to the menu trigger button.@embeddedchat/ui-elements.yarn lint), formatted with Prettier (yarn format:check), and built successfully (yarn build).Fixes #1450
Fixes #1451
Video/Screenshots
Screen.Recording.2026-11-22.224729.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1452 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.