Skip to content

fix(react): copy message links with the correct room route - #1456

Open
Vidit-001 wants to merge 2 commits into
RocketChat:developfrom
Vidit-001:fix/copy-message-link-room-routes
Open

Vidit-001 wants to merge 2 commits into
RocketChat:developfrom
Vidit-001:fix/copy-message-link-room-routes

Conversation

@Vidit-001

@Vidit-001 Vidit-001 commented Nov 22, 2026 •

Copy link
Copy Markdown

Acceptance Criteria fulfillment

  • Copy Message Link uses the Rocket.Chat route for public channels, private channels, direct messages, and livechat rooms.
  • Room identifiers and message IDs are URL-encoded. Missing room metadata triggers the existing error toast.

Fixes #1455

PR Test Details

  • Ran the actual copy handler in Node with stubbed rooms.info, clipboard, and toast calls. Reproduced the private-channel and nameless-DM failures on develop and passed eight checks on the patch covering all four routes, URL encoding, and missing or unsupported room metadata.
  • To verify in a live workspace, copy a link from an EmbeddedChat message in a public channel, private channel, or DM. Open the link while signed in as a room member and check that Rocket.Chat opens the correct room and jumps to the message.
  • Live workspace and end-to-end tests were not run.

Prepared with AI assistance.

After approval, the PR preview will be available at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1456.

Copilot AI balanced review requested due to automatic review settings November 22, 2026 19:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy Message Link uses the public channel route for private rooms and DMs

2 participants