Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close the thread view when its parent message is deleted
Acceptance Criteria fulfillment
isThreadOpen,threadMainMessageandthreadMessagesare reset, and the parent is removed from the main listFixes #1080
Changes
packages/react/src/store/messageStore.js:removeMessagechecks whether the deleted id is the active thread's parent and, in oneset, closes the thread and clears its state. This also works when the parent isn't in the loaded main list.packages/react/src/store/messageStore.test.js: 7 regression tests (parent deleted, parent absent from the list, reply deleted, unrelated/unknown id, empty state, repeated events).babel.config.js(the Rollup build config is unchanged),jest.config.jswith jsdom, and a fix for the staleRCComponentimport insrc/index.test.js, which couldn't run before.@embeddedchat/reactpatch.Video/Screenshots
N/A: this is a store-level fix covered by unit tests.
PR Test Details
yarn buildforpackages/react, ESLint and Prettier pass.Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1458 after approval.