Repository navigation
SapMachine (17) #2427 #2430 #2431 #2432: Various improvements for vitals - #2455
Merged
schmelter-sap merged 3 commits intoOct 30, 2026
Merged
Conversation
Contributor
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
Member
Author
|
Failing tests are caused by certificate errors and not related to the change. |
MBaesken
reviewed
Oct 29, 2026
MBaesken
reviewed
Oct 29, 2026
MBaesken
left a comment
MBaesken
left a comment
Member
There was a problem hiding this comment.
Looks okay too; one question about the /proc/<pid>/stat parsing.
MBaesken
approved these changes
Oct 30, 2026
Contributor
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
Member
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downported from the 21 downport.
fixes #2427
fixes #2430
fixes #2431
fixes #2432