Repository navigation
Make the redundancy check part of the database tests - #437
Merged
Merged
Conversation
this is now handled by the implication "extensive + regular + quotients of congruences => effective cocongruences" added in the PR #373
also, remove a separate redundancy script
ScriptRaccoon
force-pushed
the
redundancy-check-mandatory
branch
from
October 26, 2026 22:58
579ca41 to
2fcf173
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the redundancy check mandatory: redundant property assignments now make
pnpm db:testfail, so they are caught bypnpm db:updateand in CI. Previously, they were only reported by the separate scriptpnpm db:redundancies, which had to be run manually, so after adding new results, the assignments that became redundant were often not removed (as for Unif after #373).Changes
pnpm db:testnow runs the redundancy check as its last test. It lists all redundancies, at most one per structure and kind (satisfied or unsatisfied), and fails if there are any. An assignment that is redundant but deliberately kept must be marked withcheck_redundancy: false.pnpm db:redundanciesno longer exists.check_redundancy: false.check_redundancy: falsebut were not redundant. The marker has been removed from them: "coequalizers of kernel pairs" for FreeAb and Quiv_fc, "finite products" for Man, and "thin" for N.