Repository navigation
fix(server): preserve headless Windows service tasks - #147
Conversation
|
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Post-merge audit of f2d34b774fdced8e1d385076974ad22a447d9c1d: a remaining P2 headless-service regression was reproduced on current main (1857cd2554f068a0c75ac5f109a07afe9398ba16). Task Scheduler's registered XML can be changed to S4U without changing T3's saved XML. Reinstall, restart, and launcher update registration then reused the stale InteractiveToken value. The original test changed both copies, which hid this case.
Fixed in #158 by reading and preserving the registered logon mode at all three entry points. Existing regressions now change only the scheduler copy and cover the reverse logon-mode change plus disabled tasks. The affected cases failed before the fix; all 107 boot-service/launcher tests passed in the combined validation.
Validation used the existing Linux filesystem/process harness, not a native Windows scheduler. Next action: require #158's exact-head CI to pass before merging; a native Windows install/restart/update smoke test remains useful.
Windows services configured to run without a signed-in session were reported as needing repair. A later service install rewrote their scheduled task as interactive, leaving headless hosts unable to restart after an update.
Preserve an existing S4U logon type when rendering and checking the Windows task. Extend the Windows service test to cover status and a deferred update with that task type.
Verification:
vp test run apps/server/src/cloud/bootService.test.ts(61 passed);vp run check:changed(passed).Model and harness: GPT-6 via Codex desktop.