Skip to content

fix(server): allow more time for branch naming retries - #155

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
t3/fix-branch-name-generation-timeout
Nov 18, 2026
Merged

ScriptedAlchemy merged 1 commit into
mainfrom
t3/fix-branch-name-generation-timeout

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Why

Give worktree branch naming enough time to recover from transient provider overload. The 20-second limit discards valid names that arrive later. Isolated OpenCode requests observed Morph HTTP 429 responses with 10-second retry delays, though the exact historical timeout cause remains unproven.

What changed

  • Raise the branch naming budget from 20 to 45 seconds.
  • Extend the existing regression test with a valid response at 30 seconds and retain the hung-request fallback test at 45 seconds.

Scope

Covers the shared worktree launch path across clients and agent tools. Provider retry behavior and cancellation remain unchanged.

Tradeoffs

The longer budget gives repeated retries more room, but can delay agent startup by up to 25 additional seconds. The 45-second limit is an engineering margin, not a measured optimum. The agent still waits for the rename before starting.

Verification

  • The 30-second regression failed with the old limit and passed after the change.
  • All 72 launch-service tests passed.
  • vp run check:changed HEAD passed before commit, including affected typechecks, lint, formatting, and 74 tests.
  • Independent review found no code defects.

Implemented with Morph Kimi K3.1 and reviewed with Morph DeepSeek V4.1 Flash 1017 through OpenCode, coordinated by GPT-6 through Codex in T3 Code.

@changeset-bot

changeset-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3daee55

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 71359f9 into main Nov 18, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant