Skip to content

Return diagnostic reports for unsupported documents - #4276

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/4262-diagnostic-report-errors
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/4262-diagnostic-report-errors

Conversation

@efegokdemir

Copy link
Copy Markdown

Fixes #4262.

textDocument/diagnostic now returns an empty full report for documents the server does not diagnose, including ERB and RBS, and for files outside the workspace. Errors raised while computing diagnostics are returned as JSON-RPC errors instead of a null response.

Added server tests for unsupported documents, out-of-workspace files and failed computations.

bundle exec rake test: 3,567 runs, 54,800 assertions, 0 failures, 0 errors, 6 skips. RuboCop and Sorbet passed.

@efegokdemir
efegokdemir requested a review from a team as a code owner November 17, 2026 23:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

textDocument/diagnostic returns null instead of a report for ERB/RBS documents and failed computations

1 participant