Skip to content

Preserve spaces in Bundler settings passed to composed bundles - #4278

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/bundler-settings-spaces-4275
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/bundler-settings-spaces-4275

Conversation

@efegokdemir

Copy link
Copy Markdown

Motivation

Closes #4275. Spaces in Bundler path settings were being changed to colons, which could make the composed bundle use a path that does not exist.

Implementation

Removed the space replacement. List settings are still joined with colons, while path values retain their spaces. Added a regression test for both cases.

Automated Tests

bin/test test/setup_bundler_test.rb: 43 runs, 197 assertions, 0 failures or errors. RuboCop and git diff --check passed.

Manual Tests

Not run. To check manually, set a project’s Bundler path to vendor/my bundle, start Ruby LSP, and confirm bundle setup keeps that path unchanged.

@efegokdemir
efegokdemir requested a review from a team as a code owner November 18, 2026 22:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundler settings containing spaces are rewritten with colons when composing the bundle

1 participant