Skip to content

Hotfix Beta Release: 11/20/26 - #3375

Merged
hcarter-775 merged 2 commits into
betafrom
11/20/beta
Nov 20, 2026
Merged

hcarter-775 merged 2 commits into
betafrom
11/20/beta

Conversation

@hcarter-775

Copy link
Copy Markdown
Contributor

Description of Change

Rolling up critical Zigbee/Zwave lock changes to beta.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Channel deleted.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Test Results

   73 files    572 suites   0s ⏱️
3 469 tests 3 469 ✅ 0 💤 0 ❌
5 519 runs  5 519 ✅ 0 💤 0 ❌

Results for commit 7105b7d.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

zigbee-lock_coverage.xml

File Coverage
All files 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/yale/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/samsungsds/init.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/migrate.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils/tables.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils/utils.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_handlers/zigbee_responses.lua 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_handlers/capabilities.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock-without-codes/configurations.lua 95% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7105b7d

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

zwave-lock_coverage.xml

File Coverage
All files 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/samsung-lock/can_handle.lua 75% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/legacy-handlers/schlage-lock/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/legacy-handlers/keywe-lock/init.lua 77% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/keywe-lock/can_handle.lua 87% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/lock_utils/utils.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/lock_utils/tables.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/legacy-handlers/samsung-lock/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/schlage-lock/init.lua 78% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/legacy-handlers/zwave-alarm-v1-lock/init.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/lock_handlers/capabilities.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/lock_handlers/zwave_responses.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-lock/src/zwave-alarm-v1-lock/init.lua 43% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7105b7d

@ctowns ctowns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just a small note: commit 8854e87 has a name that implied it is a merge commit, but it actually seems to have been squashed and merged directly as a single commit via the squash and merge function. Just noting this for later since it somewhat breaks the naming convention

@ctowns ctowns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually nevermind, shouldn't this be the commit we are pulling forward? ed92d83

Not the merge commit but the actual commit? I'm not sure why it still shows the changes in the diff but in the past we have cherry-picked the actual change commits, not the merge commits.

@hcarter-775

hcarter-775 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

I don't think it matters really? It's the difference between -m 1 and -m 2 in a cherry pick. In both cases, the git history is squashed in some way.

Both take forward the changes. I can take over the other commit if you'd prefer.

@ctowns

ctowns commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Yeah I'd prefer cherry-picking the other functional commit because that is how we have handled cherry-picks in this repo, and also it makes the git history cleaner and provides a more descriptive commit name. Even yesterday as a part of the prod release, we can see that actual commits were cherry-picked rather than squashed merge commit with names like "Merge ___ from ___", so at least the name should be updated to match what is actually being cherry-picked (not the merge commit)

@hcarter-775

Copy link
Copy Markdown
Contributor Author

I think there is an argument to be made that links to a PR with the full context of the change are more clear. I will make the change.

@github-actions

Copy link
Copy Markdown

Duplicate profile check: Warning - duplicate profiles detected.
lock-modular-embedded-unlatch.yml == lock-modular.yml

@github-actions

Copy link
Copy Markdown

Profile category check: ✅ Passed - all profiles have a category defined.

hcarter-775 and others added 2 commits November 20, 2026 11:32
These locks never support codes, so none of the legacy lockCodes
handling applies to them. Promote the subdriver to the top level,
along with its configurations.lua, and mark its devices as
SLGA_MIGRATED so legacy-handlers does not also handle them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A Schlage lock refuses a duplicate PIN with STATUS_NOT_AVAILABLE, which now
returns duplicate instead of success. A masked occupied report now confirms
the add or update pending on that slot instead of being dropped, so the next
add no longer overwrites the PIN. The manufacturer-specific report check is
folded into the report handler.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Pawel <41388251+kainpets@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

matter-lock_coverage.xml

File Coverage
All files 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_sync.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 89% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/unmigrated-matter-lock/init.lua 92% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7105b7d

@github-actions

Copy link
Copy Markdown

zigbee-switch_coverage.xml

File Coverage
All files 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/tuya-multi/can_handle.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/preferences.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-strip/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/firstled-io/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient-IO/unbind_request.lua 71% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient-IO/init.lua 87% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/vzm30-sn/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/vzm32-sn/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/zll-polling/init.lua 81% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/version/init.lua 93% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/color_temp_range_handlers/init.lua 71% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7105b7d

@ctowns

ctowns commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

I think there is an argument to be made that links to a PR with the full context of the change are more clear. I will make the change.

I wholeheartedly agree - Those links can be added to the commit itself by adding the #PR value, which is something that is done automatically during via the squash and merge UI. I think we should always try squash and merge when we can we can because it 1) adds this PR name automatically, and 2) it ideally reduces the number of cherry-picks needed now that we find ourselves doing cherry-picks very frequently.

I think a descriptive commit header with the PR# included is the best option, and this is something that the squash and merge UI provides, but its also something we can add directly to commits as well in the future, so it's a good call out.

For now my suggestion was made to try to enforce some of the conventions of the repo, and I agree that adding PR# through either squash and merge or via the commit message in a merged commit is the best option for documentation.

@hcarter-775
hcarter-775 merged commit f1fe9ab into beta Nov 20, 2026
25 of 26 checks passed
@hcarter-775
hcarter-775 deleted the 11/20/beta branch November 20, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants