Repository navigation
fix(scanner): preserve option values - #125
Open
John-David Dalton (jdalton) wants to merge 1 commit into
Open
John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
John-David Dalton (jdalton)
deployed
to
socket-firewall
October 11, 2026 21:37 — with
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep commas inside Tier 1 option values instead of splitting them into separate arguments. Repeated
--exclude-pathsoptions are documented, and malformed shell quoting gives a configuration error.Verification covers argument parsing only, not end-to-end exclusions or a published image.
Implementation and validation
Only unquoted commas before a new hyphen-led option act as legacy separators. Documentation explains matching examples, Tier 1 scope, and the Basics workspace default.
Validation: 11 parser tests passed, covering repeated flags, comma lists, quoted/escaped commas, and invalid quoting. Black and Flake8 passed for the test module;
git diff --checkpassed.Automated review notes