Repository navigation
Conversation
Assisted-by: Codex:GPT-6
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9179f8f. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Basics currently inherits
SocketSDKPython/<SDK version>for Socket API requests, so request attribution cannot distinguish it from standalone SDK consumers. Sendsocket-basics/<Basics version>from both dashboard configuration reads and scan uploads, using one shared constant.Blocked on backend deployment. Keep this PR in draft and do not merge or release it until depscan recognizes
socket-basics/asbasics. Backend dependency PR has been raised. Client releases must follow deployment, not merely backend PR merge.Changes
Testing
git diff --checkpassed. Added code contains no comments requiring revision in the fourth-wall audit.Rollout and reviewer context
Prior art: SocketDev/socket-python-cli#320 by jdalton. Basics follows the same application override pattern and uses its own version rather than the SDK version. Select the unpublished patch version during release preparation after backend deployment; this draft leaves release metadata unchanged.
Note
Low Risk
Only HTTP client metadata changes; scan logic, auth, and payloads are unchanged, though attribution depends on a coordinated backend deploy.
Overview
Socket Basics no longer leaves Socket API traffic labeled as the generic Python SDK. Dashboard configuration loads (org discovery and Basics settings) and full-scan uploads now pass a shared
user_agentwhen constructingsocketdev, so outbound requests usesocket-basics/<Basics version>instead ofSocketSDKPython/<SDK version>.A small
user_agentmodule centralizes that string from the existing package version, and the Unreleased changelog records the behavior change. New tests stub HTTP at the transport layer and assert theUser-Agentheader on both the config path and the multipart scan POST.Release is blocked on backend recognizing the
socket-basics/prefix as Basics traffic (per PR description).Reviewed by Cursor Bugbot for commit 9179f8f. Configure here.