Repository navigation
fix(guardrails): treat a reference solver without a schedule as a result - #4
Merged
Merged
Conversation
When Timefold's time limit ends before construction completes a JSSP schedule, the Java wrapper threw IllegalStateException and the Python adapter turned the exit into a RuntimeError, so the row read as an adapter crash. OR-Tools and HiGHS already report the same outcome as NoSolutionFoundError. The wrapper now exits with status 3 for an incomplete schedule and the adapter raises NoSolutionFoundError with termination_status no_incumbent, keeping the hard-penalty detail. Every other non-zero exit stays an adapter error.
The stock SolverForge guardrail failed on any run_error, so HiGHS and Timefold ending a 1s or 10s limit on swv20, yn3 or ta01 without a schedule failed the SolverForge guardrail on every run, with every SolverForge row hard-feasible. Reference rows whose termination_status is no_solution or no_incumbent are now accepted as results. Reference crashes, proved infeasibility of a valid instance, rejected models, invalid fair starts and watchdog kills still fail, and SolverForge and solverforge-py rows still fail on any error. Closes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3. Timefold's incomplete JSSP schedule is reported as no_incumbent instead of an adapter crash, and the stock SolverForge guardrail accepts reference rows that end their time limit without a schedule. SolverForge rows and reference crashes still fail.
make verify-benchmark-contracts verify-stock-solverforge-guardrailson this branch: passed.