Skip to content

fix(guardrails): treat a reference solver without a schedule as a result - #4

Merged
blackopsrepl merged 2 commits into
mainfrom
fix/guardrail-reference-no-solution
Nov 9, 2026
Merged

blackopsrepl merged 2 commits into
mainfrom
fix/guardrail-reference-no-solution

Conversation

@blackopsrepl

Copy link
Copy Markdown
Contributor

Closes #3. Timefold's incomplete JSSP schedule is reported as no_incumbent instead of an adapter crash, and the stock SolverForge guardrail accepts reference rows that end their time limit without a schedule. SolverForge rows and reference crashes still fail. make verify-benchmark-contracts verify-stock-solverforge-guardrails on this branch: passed.

When Timefold's time limit ends before construction completes a JSSP schedule, the Java wrapper threw IllegalStateException and the Python adapter turned the exit into a RuntimeError, so the row read as an adapter crash. OR-Tools and HiGHS already report the same outcome as NoSolutionFoundError.

The wrapper now exits with status 3 for an incomplete schedule and the adapter raises NoSolutionFoundError with termination_status no_incumbent, keeping the hard-penalty detail. Every other non-zero exit stays an adapter error.
The stock SolverForge guardrail failed on any run_error, so HiGHS and Timefold ending a 1s or 10s limit on swv20, yn3 or ta01 without a schedule failed the SolverForge guardrail on every run, with every SolverForge row hard-feasible.

Reference rows whose termination_status is no_solution or no_incumbent are now accepted as results. Reference crashes, proved infeasibility of a valid instance, rejected models, invalid fair starts and watchdog kills still fail, and SolverForge and solverforge-py rows still fail on any error.

Closes #3
@blackopsrepl
blackopsrepl merged commit 9111abd into main Nov 9, 2026
5 checks passed
@blackopsrepl
blackopsrepl deleted the fix/guardrail-reference-no-solution branch November 9, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: stock SolverForge guardrail fails on reference solvers that find no schedule in time

1 participant