Repository navigation
Migrate the apps to the solverforge-cli 4.0 layout and SolverForge 0.25.1 - #5
Merged
Merged
Conversation
SolverForge 0.25.1 keeps the nearest list destinations in one bounded buffer per nearby cursor, with no API or configuration change. Every app now requests and locks the 0.25.1 crates, and its app metadata, README and WIREFRAME name the new runtime target.
solverforge-cli 4.0 keeps module roots to module declarations and re-exports, and expects create_constraints and its constraint-calls block in src/constraints/assemble.rs with calls written as super::<id>::constraint(). Deliveries, Fleet, Flightcrew, FSR, Hospital, Lessons and Orders defined it in an inline `mod assemble` inside src/constraints/mod.rs. Each app now declares its constraint modules, `mod assemble;` and the create_constraints re-export in mod.rs, and builds the constraint set in assemble.rs in the same order as before. Deliveries, Hospital and Lessons drop the rustfmt_skip attribute that kept the module list in reading order (the order now lives in assemble.rs), so rustfmt formats one Lessons test it used to skip. Fleet drops the neutral-scaffold comment and its shape test reads the calls from assemble.rs.
solverforge check reported 43 errors for Furnace. Furnace now follows the
layout the CLI generates and validates:
- Domain: one type per file (furnace, work_order, operator, shift,
shift_coverage_demand, furnace_assignment, operator_shift_assignment, plan)
with the managed solution and entity markers. Plan::new and the
FurnaceAssignmentInit / OperatorShiftAssignmentInit constructors build
unsolved plans for the demo seed, the API DTO and the tests;
FurnaceAssignment's five planning variables sit in one block.
- Constraints: one constraint per file whose .named(...) id equals the module
name, declared in mod.rs and assembled in assemble.rs; shared.rs keeps only
scoring helpers, so the shift-ownership and lateness rules spell out their
own streams.
- Solver providers: the four scalar groups and seven conflict repairs are
registered with `solverforge generate scalar-group|conflict-repair` in the
CLI-managed blocks of plan.rs instead of hand-written groups() and
providers(); the provider functions keep their logic and solver.toml keeps
its search policy, with repair selectors naming the new constraint ids.
- Frontend: ui-model.json is the CLI's generated file, so static/app/model.js
owns the Schedule/Crew/Orders tabs, the hard/soft split and the data-table
collections, and reads constraint ids from the CLI model.
README, AGENTS and WIREFRAME describe the new layout.
BREAKING CHANGE: Furnace constraint ids are snake_case module names (for example `changeover_gap` instead of `changeoverGap`) in score analysis and in `GET /jobs/{id}/analysis/{constraint_name}`.
Closes #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4. Three commits: 0.25.1 retarget, assemble.rs for seven apps, Furnace CLI 4.0 layout (breaking: constraint ids). Validation on the branch tip tree: root make ci-local passed (294 tests, 0 failed); make pre-release passed in all eight apps (local CI, release build, browser smoke/Playwright, every slow acceptance solve feasible on 0.25.1); solverforge check passes in all eight apps; Furnace UI checked in Chromium: Schedule/Crew/Orders/Data/REST API tabs, 30 constraint dots (22 hard, 8 soft), six data tables, no console errors.