Repository navigation
Generated format sweep: every pass × method × depth × subsampling × field × size (task #47) - #212
Merged
StuartCameronCode merged 5 commits intoNov 16, 2026
Conversation
StuartCameronCode
force-pushed
the
stuart/47-generated-format-sweep-every-pass-method
branch
from
November 16, 2026 20:39
7e63700 to
2b9c7bc
Compare
… field × size (task #47) Cases come from PassType, the schemas' methods and implementation entries, three enum axes and the worker's NATIVE_FORMATS, built through the app's ParameterConverter. Per row: the preview runs, keeps the source's depth, the variant acts, and (nightly) 8-bit vs deeper parity above the passthrough's own difference; delta-only passes get an FFV1 bit-exact check. Failing rows are pinned in knownFailures (task #56). - support/format_sweep.dart: generator, axes, fixture chain, tables - format_sweep_cases_test.dart: push gate, no worker (counts, enum <-> schema) - integration_format_sweep_test.dart: gate rows untagged, full product tagged sweep+heavy, GPU variants tagged gpu - nightly.yml: a sweep leg per bundle, results uploaded; heavy leg excludes sweep - high-bit-depth test: groups 1-2 removed (the sweep covers them) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- _Pool hands a finishing slot to the next waiter, so it can't run size+1 - fixtures written to a temp name and renamed, so a killed run can't leave a partial file the cache check accepts - inertOnFixture keys must name an existing variant, not just its filter - the delta-only group marks a GPU variant skipped instead of passing it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…in in WorkDepth's doc Since task #46 the IVTC and Soft Telecine preview shows the encode's frame for its source frame; the fixture has no pulldown, so that is the source frame unchanged and the 'acts' check is waived for both, as for Frame Rate's duplicate. WorkDepth's comment names task #48's run_within, which replaced _low_depth_change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StuartCameronCode
force-pushed
the
stuart/47-generated-format-sweep-every-pass-method
branch
from
November 16, 2026 20:42
2b9c7bc to
3b53abc
Compare
… (task #47) The Linux push gate saw vspipe die with no Python error on every row of the four presets that alone share Overlap = blocksize/4 and SearchParam 1; they pass on macOS arm64. Pinned Linux-only and flaky (the hosted fleet is mixed for AVX-512), after F2 so F2's rows keep their own match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The rebased push gate failed the same four QTGMC presets on macOS x64 and Windows (no AVX-512) as on Linux x64; both arm64 runs pass them. Pin on every non-arm64 platform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a format sweep that is generated from the code, not from hand-written lists. It checks that every pass and method runs on every source format, field flag and frame size. This is R2a of task #42's plan. Tasks #23, #29, #31, #33, #34, #35 and #37 were each caused by one untested value on one of these axes.
What it sweeps
ParameterConverter, from:PassType, classified by a switch with nodefault, so a new pass doesn't compile until it is classifiedmethodsentry andimplementationactiveWhenentryNATIVE_FORMATSentry, parsed frompixel_format.rs(4:1:1 and theyuvjformats)chainSample), so a precision bug can't hide behind empty low bits.Checks per row
Passes declared delta-only also get an FFV1 encode. The samples they promise to leave alone must be bit-exact: the low-depth guards (
_low_depth_change, DeScratch), the luma-only and chroma-only passes, rotation, crop, Edge Repair and borders.Where it runs
sweep+heavy): the full product, as its own job beside the heavy suite on every bundle. Per-row results are uploaded as an artifact.gpu, which no CI runner runs.format_sweep_cases_test.dart(push gate, no worker) checks:*Methodenum against its schema, both waysFindings
Filed together as task #56 (F1–F8):
_FieldBasedEach failing row is pinned in
knownFailureswith the error text it must fail with. A pinned row that starts passing fails the test, so the entry is removed with its fix.Groups 1–2 of
integration_high_bit_depth_filters_test.dart(six hand-picked formats) are removed because the sweep covers them. Its hand-tuned parity group stays. CLAUDE.md and ENGINEERING_NOTES are updated.Review fixes
Testing (macOS arm64, deps 1.17.0-rc1)
flutter analyze: clean.format_sweep_cases_test.dart: 33/33.workflow_dispatchofnightly.yml.🤖 Generated with Claude Code