Repository navigation
Conversation
#391) * fix(vote): let members list vote categories once results are published ListVoteCategories required vote_category:read, which members only get from the voting capability. Turning voting off to publish results left participants unable to list the categories the results page needs, and the page answered with a 500. Accept vote_result:read as well. * Update components/backend/internal/service/vote_service.go Co-authored-by: Martin Fontanet <11040743+marftn@users.noreply.github.com> --------- Co-authored-by: Sabine Maennel <5292683+sabinem@users.noreply.github.com> Co-authored-by: Martin Fontanet <11040743+marftn@users.noreply.github.com>
Co-authored-by: Sabine Maennel <5292683+sabinem@users.noreply.github.com>
The protocol v0.12.2 was released with, step by step and by hand, since this branch predates the hotfix recipes proposed for main. Includes a fresh local stack for switching between main and the release branch, and what went wrong on the way. RELEASING.md's old advice to branch from the tag now points here instead.
marftn
requested changes
Oct 30, 2026
marftn
left a comment
marftn
left a comment
Contributor
There was a problem hiding this comment.
I know this is not the final version yet, but here are some comments if that can help:
- I find the text very complicated to understand even though the topic is not that hard. It's often the case with AI so I suggest making it as concise as possible with simple sentences.
- The text references specific versions. I understand why the AI did that, but for a
HOTFIX.mdI think it is better to have something more generic. Providing concrete examples is good, but it would be better to use simple version examples (e.g.0.1.1with a hotfixes which makes it0.1.2) rather than what the text currently has (0.12.0, then suddenly0.12.2and0.12.3). Same comment for the chart version. - I would completely drop the "Deploy to prod" section, or at least make it very generic like a hint saying "don't forget to update your current deployments". Mentioning
sdsc-ordes/cloud-infra(a private repo) in a public repo is bad and makes it specific to our deployment, not to the hackathon platform in general. Also, GitOps is not enforced by this repo. Each user is free to deploy the hackathon platform however they want. - In the same spirit, I would avoid sentences like "This branch,
release/0.12, is what prod runs." This is specific to the current setup and doesn't belong in this file which is supposed to describe a protocol. A branch does not need to be running in prod to get a hotfix: any release that we still maintain should get a hotfix, whether it is deployed or not. Which versions we consider as "maintained" should probably figure in our README.
Otherwise, I think I agree with the content and think it works well with the current setup.
Pull the merged fix before bumping, target the PR at the release branch, keep the chart bump in its own commit so only the fix is cherry-picked to main, and say how prod and dev each get the fix. Fix tag names, image names and typos.
Collaborator
Author
sabinem
changed the title
Collaborator
Author
|
Closed as a fixed version is here: #400 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protocol v0.12.2 was released with, step by step and by hand, since this branch predates the hotfix recipes proposed for main. Includes a fresh local stack for switching between main and the release branch, and what went wrong on the way. RELEASING.md's old advice to branch from the tag now points here instead.