Repository navigation
Document configurable Millicast broadcast events (connectOptions.events) - #918
Draft
devin-ai-integration[bot] wants to merge 2 commits into
Draft
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
…] to opt out Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Subscribed Broadcast Events" section to the Millicast Web player guide (
millicast/playback/players-sdks/web/player/index.mdx), covering the configurableconnectOptions.eventslist in the Web SDK (OPTI-4687):viewercountandvad(unchanged behaviour);connectOptions.eventsis set, the listed events are subscribed together with the ones the player always needs (active,inactive,stopped,layers,migrate), soconnectOptions: { events: [] }opts out of the optional events (example included);webrtc: { events: [...] }.Matches the iOS/Android behaviour (OPTI-4688 / OPTI-4689). The second commit replaces the earlier wording that described a changed default.
Link to Devin session: https://dolby.devinenterprise.com/sessions/753d5ae420a64f45b9054905a4ed6ede
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/753d5ae420a64f45b9054905a4ed6ede?variant=devin