[theoplayer-bot]

This PR contains the Web API reference for OptiView Ads SDK version 1.4.0.

[MaartenRimaux]

Automated review (Devin pr-review: Claude Fable, Gemini Argon, GPT Astra) of 1c2747f

documentation#956 — OptiView Ads SDK 1.4.0 Verdict: APPROVE WITH NITS
Bot-generated replacement of the five OptiView Ads SDK API references (web, React Native, Android, iOS, Roku) for dolby-ads-sdk v1.4.0. Verified against the SDK source at the tag: every real content change matches the source (new Roku OptiViewAdsSDKIntegration section, the six new iOS resumeAdAfterForeground() DocC pages, the two React Native binding doc comments), version 1.4.0 on every platform, zero 1.3.0 leftovers, no dead links or anchors; the 2 759 "modified" iOS DocC JSON files are key-order re-serialisation only (checked by parsing both sides) and the 1 231 Android files are version-stamp bumps. Safe to merge.

Blockers / Should-fix (confirmed): none

Nits (confirmed, posted inline):

1. [NIT] Roku guide does not mention the new OptiViewAdsSDKIntegration component — ads/static/ads/v2/api-reference/roku/index.html:261 — follow-up docs PR for roku.mdx, not a reason to hold this one (Fable)

Requirements: all met — (1) all five platform references regenerated from v1.4.0 (web 129 and RN public exports ↔ pages 1:1, Android non-@suppress types all paged, iOS hidden symbols absent); (2) 1.4.0 on every landing page and Dokka footer, no 1.3.0 string under ads/static/ads/v2/api-reference/; (3) every public-API delta v1.3.0→v1.4.0 is present — web/Android doc-comment changes were already on main because release/ads-sdk-1.3.0 was republished from post-tag commits, which is why those platforms are version-only here; (4) only ads/static/ads/v2/api-reference/** is touched, all internal links/anchors and DocC routes resolve, new iOS shells are byte-identical to their siblings, no upload-artifact-rejected filenames.

Uncertain: none. Not checked by anyone: the 6 binary DocC index files (*/index/availability.index, navigator.index, data.mdb) and the rendered site — see the preview at https://docs-preview.optiview.dolby.com/pr-956/.

Rejected reviewer claims: 2 — (a) "PR body says Web API reference but all five platforms change" → true, but the template lives in .github/workflows/ads-sdk-release.yml:41, untouched by this PR, and #950 already fixes it (out of scope); (b) "RN OptiViewAdsExternalVendors.updateAssetParameterMacros says Replace macro callbacks while the interface says Merge macro values" → true, but TypeDoc renders dolby-ads-sdk react-native/src/NativeOptiViewAdsExternalVendors.ts:165 at v1.4.0 faithfully; the fix belongs in the SDK repo (out of scope).

Reviewers: Fable APPROVE WITH NITS · Gemini APPROVE · Astra APPROVE

Findings outside the changed lines

• [NIT] Roku guide does not mention the new OptiViewAdsSDKIntegration component (follow-up)

  [NIT] Roku guide does not mention the new OptiViewAdsSDKIntegration component — follow-up docs PR, not a reason to hold this generated PR.

  Problem: 1.4.0's only new Roku public surface is OptiViewAds:OptiViewAdsSDKIntegration (ad integration for the OptiView Player / THEOplayer Roku SDK), documented in this new "Other components" section. The hand-written guide ads/player-integration/optiview-ads-sdk/roku.mdx only covers the app-owned Video node path and links to the reference generically, so an OptiView Player user has no discoverable path from the guides to the new component.

  Evidence: grep -c 'OptiViewAdsSDKIntegration\|registerServerSideIntegration' ads/player-integration/optiview-ads-sdk/roku.mdx → 0; the generated section matches roku/api/OptiViewAds.json at dolby-ads-sdk v1.4.0 verbatim (field names/types/access, integrationKind = optiview-ads-sdk), and the SDK's own roku/README.md § "OptiView Player ad integration" documents it — only the public guide lags.

  Fix (separate PR): add a short "Using the OptiView Player (THEOplayer Roku SDK)" subsection to roku.mdx with the three-line snippet from this section and a link to pathname:///ads/v2/api-reference/roku/#component-OptiViewAdsSDKIntegration (anchor verified to exist on this page).

  Raised by Fable, verified by the orchestrator.

  ads/static/ads/v2/api-reference/roku/index.html:261

[devin-ai-integration]

Addressed the Roku nit in c4f2076: the Roku guide (ads/player-integration/optiview-ads-sdk/roku.mdx) now has a "Using OptiView Player" section. It covers registering OptiViewAds:OptiViewAdsSDKIntegration, setting the ssai.integration source description, and teardown order, and it links to the new API reference section.

Written by Devin