Repository navigation
Add BitNuker Workshop Sampler (2D) - #129
Conversation
TMHSDigital
left a comment
There was a problem hiding this comment.
Thanks for the entry, and for stating up front that you publish the source. I re-read the live itch page today and the three licence quotes and the AI disclosure match it word for word. A few things need fixing before this can merge.
Blocking
-
npm run validatefails on this branch (the repo's own CI needs maintainer approval to run on a first PR, so the green checks you see are Socket only):catalog/2d/bitnuker-workshop-sampler.md license "custom" must not carry license_spdx "none". That license value has no SPDX identifier.Delete the
license_spdxline entirely. -
README.mdhas unrelated damage, probably from the web editor:- The Guides table and the "short version" licence table both had their header separator changed from two columns to three (
| :--- | :--- | :--- |). Revert both to| :--- | :--- |. - The
docs/game-vs-video-licensing.mdrow was deleted from the Guides table, and thedocs/provenance.mdrow was moved belowhigh-risk.md. Restore the original order and the missing row.
The only README changes this PR should carry are the three 415 → 416 count edits and the 2D 58 → 59 row.
- The Guides table and the "short version" licence table both had their header separator changed from two columns to three (
-
CONTRIBUTING "Submitting your own source" asks publisher-submitted entries to start at
status: needs-review. Please set that; a maintainer flips it toactiveafter re-reading the licence (that re-read has now happened, so the flip can land in the merge).
Non-blocking
- Keep the paid-pack mention to the Notes bullet. The summary paragraph currently also says the items "are sold in Front View and Top-Down in the full Workshop packs"; the entry describes the free sampler only.
- "so AI tools can read what is in the file" reads as marketing copy. "Each PNG embeds title, inventory and usage notes in its metadata" says the same thing as a fact.
- The extra trailing double-space added to the last footnote line of
catalog/2d/README.mdcan go.
Counts, the 2D README row, and expectedEntryCount all check out against node site/sync-counts.mjs.
Drop license_spdx: none (not valid on a custom licence), restore the README.md tables and the game-vs-video-licensing row that the web editor dropped, keep the paid-pack mention to Notes, and record the maintainer licence re-read so the entry can stay active. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Thank you for the review and for pushing the fix commit. I checked the branch against each item: the |
TMHSDigital
left a comment
There was a problem hiding this comment.
Fixes applied by maintainer push; validate is green.
Summary
I publish this source: I am the publisher (BitNuker) submitting my own work, per CONTRIBUTING "Submitting your own source". The entry is written as a third party would (facts the source states, no comparisons with other entries, no ranking language).
New catalog entry: BitNuker Workshop Sampler — a free 12-sprite pixel art sampler for cozy workshop and crafting games (2D, PNG, 3/4 view). Source: https://bitnuker.itch.io/workshop-sampler. License: BitNuker Standard License (custom, commercial OK, credit appreciated but not required). The entry covers the free sampler only; the paid full Workshop packs are named in Notes as out of scope.
npm run countsoutput expectations (415 to 416 total, 2D 58 to 59,expectedEntryCount416, sources badge) because this PR was assembled in the GitHub web editor andnpm test/npm run validatecould not be run locally; CI will run the fullnpm run check.Note for the maintainer: the entry is at
status: activewith the licence read and quoted at the live source; feel free to re-read and setneeds-reviewif preferred.Type
Checklist
node site/new-entry.mjs <category> <id>or copiedcatalog/TEMPLATE.md(new entries)idis unique across the whole catalog## Evidencehas a dated line quoting itREADME.md, with the same licence as the frontmatternode site/sync-counts.mjsafter adding or removing entries (counts updated manually to the same targets; see Summary)stacks/README.md; no licence named in a stack's own words (n/a — no stack changes)npm test && npm run validatepasses locally (CI runs the fullnpm run check, including the build) (not run locally; CI will run it)