Skip to content

Add BitNuker Workshop Sampler (2D) - #129

Merged
TMHSDigital merged 6 commits into
TMHSDigital:mainfrom
mattzornow:add-bitnuker-workshop-sampler
Oct 23, 2026
Merged

TMHSDigital merged 6 commits into
TMHSDigital:mainfrom
mattzornow:add-bitnuker-workshop-sampler

Conversation

@mattzornow

Copy link
Copy Markdown
Contributor

Summary

I publish this source: I am the publisher (BitNuker) submitting my own work, per CONTRIBUTING "Submitting your own source". The entry is written as a third party would (facts the source states, no comparisons with other entries, no ranking language).

New catalog entry: BitNuker Workshop Sampler — a free 12-sprite pixel art sampler for cozy workshop and crafting games (2D, PNG, 3/4 view). Source: https://bitnuker.itch.io/workshop-sampler. License: BitNuker Standard License (custom, commercial OK, credit appreciated but not required). The entry covers the free sampler only; the paid full Workshop packs are named in Notes as out of scope.

  • Licence verified at the source on 2026-10-22.
  • I read the license myself at the live source; the entry's ## Evidence quotes it with the date.
  • Counts updated manually to match npm run counts output expectations (415 to 416 total, 2D 58 to 59, expectedEntryCount 416, sources badge) because this PR was assembled in the GitHub web editor and npm test / npm run validate could not be run locally; CI will run the full npm run check.

Note for the maintainer: the entry is at status: active with the licence read and quoted at the live source; feel free to re-read and set needs-review if preferred.

Type

  • New catalog entry
  • License / metadata correction
  • Starter stack
  • Docs or site

Checklist

  • Started from node site/new-entry.mjs <category> <id> or copied catalog/TEMPLATE.md (new entries)
  • id is unique across the whole catalog
  • Live license checked today; ## Evidence has a dated line quoting it
  • Row added to the category README.md, with the same licence as the frontmatter
  • Ran node site/sync-counts.mjs after adding or removing entries (counts updated manually to the same targets; see Summary)
  • Stacks: followed stacks/README.md; no licence named in a stack's own words (n/a — no stack changes)
  • npm test && npm run validate passes locally (CI runs the full npm run check, including the build) (not run locally; CI will run it)
  • If I publish the source, I say so above; if an agent or script drafted this, every licence fact was still read at the source by me

@TMHSDigital TMHSDigital left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the entry, and for stating up front that you publish the source. I re-read the live itch page today and the three licence quotes and the AI disclosure match it word for word. A few things need fixing before this can merge.

Blocking

  1. npm run validate fails on this branch (the repo's own CI needs maintainer approval to run on a first PR, so the green checks you see are Socket only):

    catalog/2d/bitnuker-workshop-sampler.md license "custom" must not carry license_spdx "none". That license value has no SPDX identifier.
    

    Delete the license_spdx line entirely.

  2. README.md has unrelated damage, probably from the web editor:

    • The Guides table and the "short version" licence table both had their header separator changed from two columns to three (| :--- | :--- | :--- |). Revert both to | :--- | :--- |.
    • The docs/game-vs-video-licensing.md row was deleted from the Guides table, and the docs/provenance.md row was moved below high-risk.md. Restore the original order and the missing row.
      The only README changes this PR should carry are the three 415 → 416 count edits and the 2D 58 → 59 row.
  3. CONTRIBUTING "Submitting your own source" asks publisher-submitted entries to start at status: needs-review. Please set that; a maintainer flips it to active after re-reading the licence (that re-read has now happened, so the flip can land in the merge).

Non-blocking

  • Keep the paid-pack mention to the Notes bullet. The summary paragraph currently also says the items "are sold in Front View and Top-Down in the full Workshop packs"; the entry describes the free sampler only.
  • "so AI tools can read what is in the file" reads as marketing copy. "Each PNG embeds title, inventory and usage notes in its metadata" says the same thing as a fact.
  • The extra trailing double-space added to the last footnote line of catalog/2d/README.md can go.

Counts, the 2D README row, and expectedEntryCount all check out against node site/sync-counts.mjs.

Drop license_spdx: none (not valid on a custom licence), restore the
README.md tables and the game-vs-video-licensing row that the web editor
dropped, keep the paid-pack mention to Notes, and record the maintainer
licence re-read so the entry can stay active.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@mattzornow

Copy link
Copy Markdown
Contributor Author

Thank you for the review and for pushing the fix commit. I checked the branch against each item: the license_spdx line is gone, the README.md Guides table and short-version table are back to two-column separators with the game-vs-video-licensing.md row restored and provenance.md back in position (only the count edits remain), and the entry summary keeps the paid-pack mention to Notes with the factual wording about PNG metadata. I did not change status, since your fix commit records the maintainer licence re-read in the entry so it can stay active. Let me know if you would like anything else adjusted.

@TMHSDigital TMHSDigital left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes applied by maintainer push; validate is green.

@TMHSDigital
TMHSDigital merged commit 295ab86 into TMHSDigital:main Oct 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants