Repository navigation
fix(plugin-oracle): read NCHAR columns under a UTF8 national charset - #3280
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On an Oracle database whose national character set is UTF8, any query returning an NCHAR, NVARCHAR2 or NCLOB value failed with "The Oracle driver reported an error (nationalCharsetNotSupported)", and the next statement on that connection failed as "connection closed". oracle-nio only handled AL16UTF16. UTF8 values arrive as CESU-8 (measured on Oracle 23ai).
Change
scripts/probes/check-oracle-national-charset.shchecks NCHAR reads and writes against a live database.Verified
Fork unit tests cover CESU-8 and row framing. The probe passes on a UTF8 and an AL16UTF16 database: Lao text, U+1D11E, a 20,008-character NCLOB, literal and bind writes.
Not in this PR
plugin-oracle-v*release.¿¿¿with no error (measured on WE8MSWIN1252). Separate fix:UNISTRliterals or NCHAR binds.