Repository navigation
feat(docs): ask before Google Analytics sets cookies on the docs - #3286
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
docs.tablepro.app loads GA4 with no consent step. One page view sets
_gaand_ga_GQYNPKSK83on.tablepro.app, the parent domain. tablepro.app's privacy policy says Google Analytics cookies are not set until the reader allows them, so that sentence was false for anyone who had opened the docs.Change
integrations.cookiesindocs.jsonholds all Mintlify analytics back until local storage hastablepro:analytics-consent = granted.docs/consent.js: the same question, wording and equal Allow and Decline buttons as tablepro.app, plus a "Cookie settings" control in the footer to change the answer.Verified
Headless Chrome against
mint dev: first visit and after Decline send no request to Google and set no cookie; after Allow the page reloads and GA loads. No overlap with the assistant launcher at 1280 and 390 wide, light and dark.Not in this PR