Skip to content

Implement cyd-2432s028rv2 - #746

Merged
KenVanHoeylandt merged 2 commits into
mainfrom
cyd-2432s028rv2
Nov 11, 2026
Merged

KenVanHoeylandt merged 2 commits into
mainfrom
cyd-2432s028rv2

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added initial support for the CYD 2432S028R v2 board, including its display, touch input, SD storage, and RGB LED.
    • Added support for custom display initialization sequences, while retaining the default sequence when none is configured.
  • Documentation
    • Added the Apache License 2.0 text.
    • Board support is marked incubating, is limited to version 2, and has not been tested on physical hardware.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The changes add a device definition for the CYD 2432S028R v2, including its ESP32 peripherals, display, touch controller, and device properties. The ILI9341 driver gains an optional custom initialization sequence. The driver validates and parses the sequence, passes parsed commands to the panel configuration, and frees allocated command storage during cleanup.

Merge Risk: Minimal · up to e40ed

This adds CYD 2432S028R v2 device support and an optional custom ILI9341 init sequence, with the init-sequence element type now const across the display bindings. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Implement cyd-2432s028rv2" names the main change. The PR adds a new device package for the CYD 2432S028R v2 board, including its device tree, device properties, and module metadata. It also…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Implement cyd-2432s028rv2" names the main change. The PR adds a new device package for the CYD 2432S028R v2 board, including its device tree, device properties, and module metadata. It also adds supporting init-sequence support in the ILI9341 driver and const qualifiers in several bindings. The title is short and specific, and it does not describe the driver or binding changes. That gap is expected for a title.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c77a5f76-9aea-4c6e-96a7-016347d8a604
Commits

Reviewing files that changed from the base of the PR and between 7d802bd and e40ed9a.

Files selected for processing: 9

  • Drivers/co5300-module/bindings/chipone,co5300.yaml
  • Drivers/ili9341-module/bindings/ilitek,ili9341.yaml
  • Drivers/ili9881c-module/bindings/ilitek,ili9881c.yaml
  • Drivers/jd9165-module/bindings/jdi,jd9165.yaml
  • Drivers/ssd1306-module/bindings/solomon,ssd1306.yaml
  • Drivers/st7121-module/bindings/sitronix,st7121.yaml
  • Drivers/st7123-module/bindings/sitronix,st7123.yaml
  • Drivers/st7701-module/bindings/sitronix,st7701-dsi.yaml
  • Drivers/st7701-module/bindings/sitronix,st7701.yaml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f8aa56d-3ba8-412e-afee-540a43880714
Commits

Reviewing files that changed from the base of the PR and between bb4c220 and 7d802bd.

Files selected for processing: 7

  • Devices/cyd-2432s028rv2/LICENSE-Apache-2.0.md
  • Devices/cyd-2432s028rv2/cyd,2432s028rv2.dts
  • Devices/cyd-2432s028rv2/device.properties
  • Devices/cyd-2432s028rv2/module.yaml
  • Drivers/ili9341-module/bindings/ilitek,ili9341.yaml
  • Drivers/ili9341-module/include/drivers/ili9341.h
  • Drivers/ili9341-module/source/ili9341.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@KenVanHoeylandt
KenVanHoeylandt merged commit 421b613 into main Nov 11, 2026
77 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the cyd-2432s028rv2 branch November 11, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant