You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Wio Tracker L2 Pro: software keyboard and full PSRAM for apps - #747
button-control registers a KEYBOARD_TYPE device without is_present, so lvgl_hardware_keyboard_is_available() returned true and text fields never showed the software keyboard (for example the Wi-Fi password in the setup wizard). It now implements is_present and returns false, the buttons work as before. The Waveshare ESP32-S3-Touch-LCD-1.47 uses it the same way. On boards with only buttons and no touch, a focused text field shows the software keyboard again, as before #561 (not tested on those boards).
Tested on a Wio Tracker L2 Pro
Summary by CodeRabbit
Bug Fixes
Text fields continue to display the software keyboard when the button control module is connected; it is no longer treated as a hardware keyboard.
- button-control reports that it is not a hardware keyboard, so text fields show the software keyboard on touch boards with buttons. Key input from the buttons is unchanged.
- Wio Tracker L2 Pro: hardware.spiRamXipDisabled=true, as on the T-Deck. XIP from PSRAM copied about 4 MB of firmware into the 8 MB PSRAM, so apps that need 8 MB (requires.ram) were hidden.
No actionable comments were generated in the recent review.
Walkthrough
The Wio Tracker L2 Pro device properties now set hardware.spiRamXipDisabled to true. The PSRAM boot-fix comment written by device.py now ends with a newline. The button-control module now reports that it is not present. Its README states that text fields continue to show the software keyboard.
Merge Risk: Minimal · up to 627e9
The change restores the software keyboard on the Wio Tracker L2 Pro and frees PSRAM for apps. No actionable merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the two changes in the PR: a software keyboard fix for the Wio Tracker L2 Pro (button-control is_present returns false so LVGL does not treat a hardware keyboard as present) and the PS…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check
Explanation
The title names the two changes in the PR: a software keyboard fix for the Wio Tracker L2 Pro (button-control is_present returns false so LVGL does not treat a hardware keyboard as present) and the PSRAM change (spiRamXipDisabled=true so apps can use full PSRAM). Both appear in the changeset and objectives, so the title is related to the main change.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 92bcb8e6-9dd5-4c35-818e-c93a336d19cb
Commits
Reviewing files that changed from the base of the PR and between 692aa30 and 627e9b3.
Files selected for processing: 1
device.py
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
⚠️ Outside diff range comments (1)
Major · Add a newline after the PSRAM comment so… · device.properties:262
Devices/seeed-wio-tracker-l2-pro/device.properties:262 Major · Functional Correctness · Quick win
Add a newline after the PSRAM comment so CONFIG_SPIRAM_FETCH_INSTRUCTIONS=n is emitted.
In the disabled branch of write_psram (device.py:262-263), the comment write has no trailing newline. The CONFIG_SPIRAM_FETCH_INSTRUCTIONS=n assignment is appended to the comment line and is not written as a configuration entry. The other two =n assignments are unaffected.
Suggested fix
- output_file.write("# Fix error \"PSRAM space not enough for the Flash instructions\" on boot:")+ output_file.write("# Fix error \"PSRAM space not enough for the Flash instructions\" on boot:\n")
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 0e20882e-b944-4d9f-b217-c92a9358c624
Commits
Reviewing files that changed from the base of the PR and between 5b46f6a and 692aa30.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
button-control registers a KEYBOARD_TYPE device without is_present, so lvgl_hardware_keyboard_is_available() returned true and text fields never showed the software keyboard (for example the Wi-Fi password in the setup wizard). It now implements is_present and returns false, the buttons work as before. The Waveshare ESP32-S3-Touch-LCD-1.47 uses it the same way. On boards with only buttons and no touch, a focused text field shows the software keyboard again, as before #561 (not tested on those boards).
Tested on a Wio Tracker L2 Pro
Summary by CodeRabbit