[KenVanHoeylandt]

Summary by CodeRabbit

• New Features
  • Added support for the ESP32-S31-Korvo-1 V1.1, including its 4.3-inch display, audio, touch, and microSD storage hardware.
  • Added ES8389 audio codec support, including optional speaker amplifier control; ES8388 support remains available.
• Bug Fixes
  • Improved LVGL shutdown handling to reduce the risk of tasks accessing the display port during deinitialization.

[coderabbitai]

Caution

Review failed

The pull request is closed.

No actionable comments were generated in the recent review.

Walkthrough

The changes add ESP32-S31-Korvo-1 board configuration and device-tree declarations. The shared ES838x module now registers ES8388 and ES8389 drivers, with ES8389 configuration for its optional amplifier pin and DAC reference. The Tab5 module uses the renamed driver module. LVGL shutdown now clears its initialized flag before port deinitialization and restores it if deinitialization fails.

Merge Risk: Minimal · previous review 54366

This change adds Korvo-1 board support and extends the ES838x driver to ES8389. No actionable merge-blocking risk remains after review.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "Espressif S31 Korvo implementation" matches the main change. The PR adds the ESP32-S31-Korvo-1 device definition, including its README, device properties, device tree, and module.yaml. It a…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "Espressif S31 Korvo implementation" matches the main change. The PR adds the ESP32-S31-Korvo-1 device definition, including its README, device properties, device tree, and module.yaml. It also renames and generalizes the ES8388 driver into an ES838x driver that supports ES8389. The title names the target device but does not mention the driver rename or the LVGL fix, which is acceptable because the title need not cover every detail. The commit message "Fixes" adds no intent, so it does not affect the assessment.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 31f4f929-9957-4e92-9361-d573af974191

Commits

Reviewing files that changed from the base of the PR and between 43b05f3 and 543660c.

Files selected for processing: 2

• Devices/espressif-esp32-s31-korvo-1/module.yaml
• Drivers/es838x-module/source/es838x.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

[coderabbitai]

Actionable comments posted: 2

Review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: bc77297e-ec7b-461d-99ac-18e9732f906f

Commits

Reviewing files that changed from the base of the PR and between 421b613 and 43b05f3.

Files selected for processing: 22

• Devices/espressif-esp32-s31-korvo-1/LICENSE-Apache-2.0.md
• Devices/espressif-esp32-s31-korvo-1/README.md
• Devices/espressif-esp32-s31-korvo-1/device.properties
• Devices/espressif-esp32-s31-korvo-1/espressif,esp32-s31-korvo-1.dts
• Devices/espressif-esp32-s31-korvo-1/module.yaml
• Devices/m5stack-tab5/module.yaml
• Drivers/es8388-module/source/module.cpp
• Drivers/es838x-module/CMakeLists.txt
• Drivers/es838x-module/LICENSE-Apache-2.0.md
• Drivers/es838x-module/README.md
• Drivers/es838x-module/bindings/everest,es8388.yaml
• Drivers/es838x-module/bindings/everest,es8389.yaml
• Drivers/es838x-module/include/bindings/es8388.h
• Drivers/es838x-module/include/bindings/es8389.h
• Drivers/es838x-module/include/drivers/es8388.h
• Drivers/es838x-module/include/drivers/es8389.h
• Drivers/es838x-module/include/es838x_module.h
• Drivers/es838x-module/module.yaml
• Drivers/es838x-module/source/es838x.cpp
• Drivers/es838x-module/source/module.cpp
• Drivers/es838x-module/source/symbols.c
• Modules/lvgl-module/source/arch/lvgl_esp32.c

Files with no reviewable changes: 1

• Drivers/es8388-module/source/module.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.