Skip to content

Keyboard fix, remote viewer added - #749

Merged
KenVanHoeylandt merged 3 commits into
mainfrom
develop
Nov 12, 2026
Merged

KenVanHoeylandt merged 3 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Keyboard capabilities

  • KeyboardApi now has uint32_t capabilities as its first member.
  • KEYBOARD_CAPABILITY_RESTRICTED marks limited keyboards. is_present was dropped.
  • Added keyboard_has_capability.
  • All KeyboardApi implementations have explicit .capabilities.

Kernel display hook

  • struct DisplayHook with on_* callbacks and display_set_hook().
  • The draw hook runs before the driver call. The other hooks run after it.
  • Exported in symbols.c and covered by display_hook_test.cpp.

Remote access (Modules/development-module)

  • Display viewer with zoom and rotation
  • Remote keyboard and touch driver
  • Screenshot taking

Viewer (Buildscripts/TactilitySDK/Tools)

remote.py and _remote_viewer.py use Custom2kinter.

Summary by CodeRabbit

  • New Features
    • Added remote device viewing through the tt remote command, with live display updates, screenshots, rotation and zoom controls, and keyboard and touch input.
    • Remote sessions can report display and input limitations, and only one remote session can run at a time.
  • Improvements
    • Display orientation is reflected in the remote view, including software-rotated displays.
    • SDK startup errors now provide clearer guidance for missing UI and image dependencies.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

Adds remote display sessions with display-state and rectangle streaming, virtual keyboard and touch input, and remote-session routing. Adds kernel display hooks, keyboard capability reporting, and LVGL orientation support. Adds an SDK command and viewer for remote display and input. Also updates dashboard dependency guidance and widget arguments.

Merge Risk: Low · previous review 83abc

The remote viewer can leave a typed key held down on the device when Shift changes between press and release. The dashboard may fail to start on older CustomTkinter 5.2.x installs because of the progress-bar argument. Both are narrow and have small fixes, so the change is mergeable with these follow-ups.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Keyboard fix, remote viewer added" names two real parts of the changeset. The keyboard changes add a KeyboardApi capabilities field, KEYBOARD_CAPABILITY_RESTRICTED, and keyboard_has_capabil…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Keyboard fix, remote viewer added" names two real parts of the changeset. The keyboard changes add a KeyboardApi capabilities field, KEYBOARD_CAPABILITY_RESTRICTED, and keyboard_has_capability, and remove is_present. The remote viewer is added through remote.py and _remote_viewer.py, along with the development-module remote access. The title does not name the largest change, which is the remote access and viewer feature, and the word "fix" is broad because the keyboard change is an API refactor rather than a clear bug fix. The title is therefore partially related: it refers to real aspects of the change but is broad and does not state the main point.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9828f05b-1ae2-45e2-8578-824fe5c97077
Commits

Reviewing files that changed from the base of the PR and between 5a7d633 and f98f8f0.

Files selected for processing: 45

  • Buildscripts/TactilitySDK/Tools/_remote_viewer.py
  • Buildscripts/TactilitySDK/Tools/remote.py
  • Buildscripts/TactilitySDK/Tools/shell.py
  • Buildscripts/TactilitySDK/Tools/ui.py
  • Devices/cl32-v04/source/cl32_v4_keyboard.cpp
  • Devices/m5stack-tab5/Source/devices/tab5_keyboard.cpp
  • Devices/simulator/Source/drivers/sdl_keyboard.cpp
  • Drivers/button-control-module/source/button_control.cpp
  • Drivers/gpio-encoder-module/source/gpio_encoder.cpp
  • Drivers/gpio-trackball-module/source/gpio_trackball_child.cpp
  • Drivers/lilygo-module/source/tdeck_keyboard.cpp
  • Drivers/m5stack-module/source/cardputer_adv_keyboard.cpp
  • Drivers/m5stack-module/source/cardputer_keyboard.cpp
  • Drivers/rgb-display-module/source/rgb_display.cpp
  • Drivers/rotary-button-module/source/rotary_button.cpp
  • Drivers/tca8418-module/source/tca8418.cpp
  • Modules/development-module/CMakeLists.txt
  • Modules/development-module/README.md
  • Modules/development-module/include/development/remote_access.h
  • Modules/development-module/private/development/protocol.h
  • Modules/development-module/private/development/remote.h
  • Modules/development-module/private/development/remote_input.h
  • Modules/development-module/private/development/session.h
  • Modules/development-module/source/module.cpp
  • Modules/development-module/source/protocol.cpp
  • Modules/development-module/source/remote.cpp
  • Modules/development-module/source/remote_input.cpp
  • Modules/development-module/source/server.cpp
  • Modules/development-module/source/session_app.cpp
  • Modules/development-module/tests/source/protocol_test.cpp
  • Modules/development-module/tests/source/server_test.cpp
  • Modules/lvgl-module/include/lvgl/devices/display.h
  • Modules/lvgl-module/source/devices/display.cpp
  • Modules/lvgl-module/source/devices/keyboard.cpp
  • Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble_hid_host.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_hid.cpp
  • Tactility/Source/InitModules.cpp
  • Tactility/Source/InitServices.cpp
  • TactilityKernel/include/tactility/drivers/display.h
  • TactilityKernel/include/tactility/drivers/keyboard.h
  • TactilityKernel/source/drivers/display.cpp
  • TactilityKernel/source/drivers/keyboard.cpp
  • TactilityKernel/source/symbols.c
  • TactilityKernel/tests/source/display_hook_test.cpp
  • TactilityKernel/tests/source/keyboard_test.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread Buildscripts/TactilitySDK/Tools/ui.py Resolved

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to GitHub limitations.

⚠️ Outside diff range comments (1)

Minor · Use a width fallback for CustomTkinter 5.2.x. · ui.py:1035

Buildscripts/TactilitySDK/Tools/ui.py:1035
Minor · Stability & Availability · Quick win

Use a width fallback for CustomTkinter 5.2.x.

CustomTkinter 5.2.2 CTkProgressBar has no length parameter. It forwards unknown keyword arguments to the base widget, which raises TclError. When CustomTkinter 5.2.x is installed, length=180 stops DevConsole initialization.

The Custom2kinter documentation lists length, so the Custom2kinter path is not affected. Use a fallback that tries length first and then width:

Suggested fix

-        self.progress = ctk.CTkProgressBar(bottom, length=180, mode="indeterminate")
+        try:
+            self.progress = ctk.CTkProgressBar(bottom, length=180, mode="indeterminate")
+        except Exception:  # CustomTkinter 5.2.x has no `length` option.
+            self.progress = ctk.CTkProgressBar(bottom, width=180, mode="indeterminate")
Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 650bb86b-e588-41c7-bf4d-195262c25843
Commits

Reviewing files that changed from the base of the PR and between f98f8f0 and 83abc77.

Files selected for processing: 6

  • Buildscripts/TactilitySDK/Tools/_remote_viewer.py
  • Buildscripts/TactilitySDK/Tools/ui.py
  • Modules/development-module/tests/source/server_test.cpp
  • TactilityKernel/include/tactility/drivers/display.h
  • TactilityKernel/source/drivers/display.cpp
  • TactilityKernel/tests/source/display_hook_test.cpp
Files skipped from review as they are similar to previous changes: 1

  • TactilityKernel/include/tactility/drivers/display.h

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@KenVanHoeylandt
KenVanHoeylandt merged commit 78f9fa7 into main Nov 12, 2026
2 of 21 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the develop branch November 12, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant