Repository navigation
Conversation
…es preserve module scope
🦋 Changeset detectedLatest commit: 34c2ca0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe patch exports ChangesTable Core declarations
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR exports 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description clearly explains the problem, motivation, and implementation changes. It does not include the required Checklist section or the Release Impact section with the applicable checkbox selected. Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
When bundling declaration files with rolldown-plugin-dts, emitted
.d.tsfiles that lack top-levelexportstatements are treated by TypeScript as ambient scripts rather than ES modules. As a result, private top-level type aliases (such astype RangeValue = Date | numberinaggregationFns.ts) are treated as ambiently declared and leak into downstream consumer declaration emit (declaration: true), failing with:Changes
RangeValuetype inpackages/table-core/src/features/row-aggregation/aggregationFns.tsso it is part of the public feature types re-exported from@tanstack/table-core.scripts/rewrite-table-core-dts.mjsto ensure every emitted declaration file maintains ES module scope by appendingexport {};if no export statements exist in the file.@tanstack/table-core.Summary by CodeRabbit
RangeValuetype for consumers working with range aggregations.