Repository navigation
Split heavy services out of the documentation Worker - #1385
Merged
Merged
Conversation
|
|
Important Review skippedToo many files! This PR contains 312 files, which is 162 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
📒 Files selected for processing: 312
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 4aec6a9 | Commit Preview URL Branch Preview URL |
Oct 15 2026, 11:35 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation requests previously carried the chat backend, image renderer, project templates and browser-only catalogs in the same Worker upload, even when those modules were lazy. Keep one Start app and browser route tree, but deploy OG generation, chat services and project generation as auxiliary Workers. Remove the chat app and icon catalog from the server build through client-only imports.
Also cache the docs manifest, refresh stale positive content in the background, keep docs HTML private and uncached, and add request timings plus build guards that prevent heavy modules returning to the site upload.
Validation:
The site upload is about 58% smaller. An 80-request controlled payload comparison reduced first-instance median latency from 1,048 ms to 472 ms. Production docs samples had a roughly unchanged settled median near 250 ms, so this is not a 55% end-to-end page speedup. Raw measurements and limitations are in docs/worker-split-validation.md and docs/worker-split-measurements.json.
The production namespaces and existing workflow have already moved to tanstack-chat without changing their IDs. The deployment script handles the first staged rollout and ordinary subsequent deployments, checking child credentials before making changes. This configuration needs to reach main before its next production deployment.
The saved session was already expired before rollout. Authentication rejection checks pass, but a successful signed-in check needs a fresh login.
Final deployment incorporates main through b416acb. Site version: bb60eccc-63a1-4412-8670-c7b3d77a4bcf. A further 24-request sample immediately after that redeployment returned 200 throughout, with median TTFB 283.6 ms and p95 1,496.5 ms. This reinforces the limitation above: the live samples do not establish an overall docs response improvement, despite the controlled reduction in cold payload preparation time.