Repository navigation
feat: GSM Secrets - Read secret inputs through the store at launch - #475
Open
yuechao-qin wants to merge 5 commits into
Open
yuechao-qin wants to merge 5 commits into
yuechao-qin wants to merge 5 commits into
Conversation
# Conflicts: # cloud_pipelines_backend/secret_value_store.py # tests/test_secret_value_store.py
…ore, at launch A launch only reads: get takes no session, so nothing moves or commits during a launch.
# Conflicts: # tests/test_secret_store.py
Ark-kun
reviewed
Nov 19, 2026
| sleep_seconds_between_queue_sweeps: float = 1.0, | ||
| output_data_purge_duration: datetime.timedelta = None, | ||
| *, | ||
| secret_store: secret_store.SecretStore | None = None, |
Contributor
There was a problem hiding this comment.
Let's rename to internal _secret_store for a bit of time. It's trivial to rename to public secret_store in any time in the future.
Ark-kun
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A launch now finds a secret input in the secret store when it is no longer in the database: give
OrchestratorService_Sqlasecret_store, and the launch reads the database first, then the store. Without a store, nothing changes.secrettable)?With no
secret_storegiven, only the first and third rows can happen, exactly as today.Why
With #474, the secret routes move each row into the store on first use, so a launch can no longer rely on the table alone.
A launch only reads:
gettakes no session and never moves a row, so the launch transaction stays as it is today, with no commit and no row lock. The row comes first because a row that still exists holds the same value as any copy the store has: a move saves to the store before it deletes the row, in one commit.Verification
tests/test_secret_store.py, launching a one-task pipeline throughOrchestratorService_Sqlwith a mock launcher: a row reaches the task with or without a store and stays in the table, with the store left empty; a secret only in the store is read from it; a missing secret is today's user error with or without a store, and nothing is launched; a failinggetfails the launch with the store's error.tests/instrumentation/test_execution_tracing.pyfail onmaster. Also passes on Python 3.14.