Repository navigation
[DO NOT MERGE] - Testing #467 on oasis staging - #484
Closed
yuechao-qin wants to merge 1 commit into
Closed
yuechao-qin wants to merge 1 commit into
yuechao-qin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. A test branch for oasis staging: it adds #467 (secret env vars only for secrets consumed as values) to the commit oasis staging already pins, so staging can run it before it merges.
What is in it
de0ac79, the commit oasis staging pins today and the head of #482, plus #467's own commit (d6f88f3), cherry-picked rather than merged, so themastercommits staging does not run yet stay out.Base
The base is
ycq/staging-integration-gsm, #482's branch, atde0ac79. The diff is therefore only #467: 2 files, +62 / −11.Checks
git patch-idequals #467's (017247fdad0f)pytestde0ac79: #467 replaces one test with another. The 22tests/instrumentation/test_execution_tracing.pyfailures also fail onde0ac79de0ac79's codeblack --check