Repository navigation
Develop to Stage - #162
Merged
Merged
Develop to Stage#162
Conversation
Pushes the workspaces-backend to the app service on push
…push Update push-docker-image.yml
added other step for building the environment
…push Update push-docker-image.yml
v3 deployment
…push Update push-docker-image.yml
…push Update push-docker-image.yml
name check
…push Update push-docker-image.yml
Lists the workspace's current elements with a non-empty fixme tag (the key in any case, e.g. FIXME), newest first, each with its note, version, changeset, timestamp, tags and a location: a node's own, or the middle of a way's nodes (none for a relation). The OSM API can't search by tag, so, like the bbox and adiff endpoints, this reads the workspace's tables directly. Anyone who can open the workspace can call it. Checked against a real Postgres with the OSM current_* tables: nodes, ways and relations are found, empty notes and deleted elements aren't. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Implement workspace creation permissions based on TDEI roles and update tests * Implement TDEI dataset fetching and workspace creation validation based on dataset status and project group * Implement workspace creation permission checks and related API endpoint * Rename TDEI client variable for consistency in security and test files * Add TDEI API backend URL and enhance dataset handling in workspace creation - Introduced TDEI_API_BACKEND_URL in .env.example and docker-compose.local.yml for environment configuration. - Added same_uuid function to compare UUIDs in a case-insensitive manner. - Enhanced TdeiDataset class to include data_type and added matches_type method for workspace type validation. - Updated fetch_tdei_dataset to handle dataset type and improved error handling for TDEI API responses. - Modified WorkspaceRepository to enforce dataset type restrictions during workspace creation. - Expanded integration and unit tests to cover new dataset type validations and TDEI API error scenarios. * Document the workspace creation rule in CLAUDE.md Who may create a workspace (POC, or the data generator of the matching type), the extra checks when creating from a TDEI dataset, and that tdei-admin gets no extra rights. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Normalize TDEI project group role names Trim and lowercase the roles TDEI returns so "POC" or " poc " grant the same rights as "poc", as the frontend's hasCreationRole already does. Roles the backend doesn't model (e.g. tdei-admin) are dropped; they granted nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Require TDEI_API_BACKEND_URL with no default A dev default would quietly send prod tokens to api-dev.tdei.us when a deployment doesn't set it. Fail at startup instead, including for the empty string docker-compose passes when the variable is unset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Jeff Maki <hello@jeffmaki.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
- Apply gig_only, which the ScoutRoute apps already send: only OSW workspaces open to external apps. lat, lon and radius stay ignored on purpose. - Don't load the geometry column or join in the long-form quest and imagery definitions; the list response sends none of them. - Gzip responses from this service's own API (/api/v1/) for clients that accept it. Proxied OSM traffic is left as received. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…lth version (#160) * Say at startup whether errors reach Sentry Without SENTRY_DSN the Sentry SDK silently sends nothing; the App Services ran that way and nobody could tell. Log a warning when it's missing, and the environment and release when it's set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bake the commit into the image as CODE_VERSION Sentry's release (and the startup log line) read CODE_VERSION, which nothing set, so every event reported release "unknown". The image workflows now pass the commit SHA as a build arg; the Dockerfile sets it last so a new commit doesn't invalidate the dependency layers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Report the running commit from /health /health now returns {"status": "ok", "version": <CODE_VERSION>}, so a deploy can be confirmed from outside. "unknown" for an image built without the build arg. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Staging's only commit is the squash of #155, whose changes develop already has; keep develop's version of tests/unit/test_workspace_repository.py, which includes them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings these to Stage (replaces #161, which conflicted):
The
push-docker-image.ymlupdates (#148–#152) and the fixmes endpoint (#154) are already on Stage from #155. They show up in this PR's commit list because #155 was squash-merged, but their changes are already there.This comes from a branch of
developwithstagingmerged in, because that squash conflicted with later changes totests/unit/test_workspace_repository.py. The resolution keepsdevelop's version, which already contains everything from #155, so the branch's files are identical todevelop.Note for #160:
ws-backend-stagehas noSENTRY_DSNorENVset, so after this deploys its startup log should warn that errors aren't reported to Sentry.🤖 Generated with Claude Code