Repository navigation
Leave tdeiMetadata and kartaViewToken out of GET /workspaces/mine - #163
Merged
Merged
Conversation
For a workspace created from a TDEI dataset, tdeiMetadata is the whole
dataset record, so it made the list large; the dashboard now fetches it
for the selected workspace from GET /workspaces/{id}. kartaViewToken was
sent to every member of the project group; no client reads it from the
list. The always-null longFormQuestDef and imageryListDef go too.
/mine now uses WorkspaceSummaryResponse; WorkspaceResponse extends it for
the single-workspace GET, which still sends all four. The list query no
longer loads tdeiMetadata.
Deploy after the frontend change that reads tdeiMetadata per workspace.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Merged
jeffmaki
added a commit
that referenced
this pull request
Nov 2, 2026
* Update push-docker-image.yml
Pushes the workspaces-backend to the app service on push
* Update push-docker-image.yml
added other step for building the environment
* Update push-docker-image.yml
v3 deployment
* Update push-docker-image.yml
* Update push-docker-image.yml
name check
* Add GET /workspaces/{id}/fixmes for the review queue (#154)
Lists the workspace's current elements with a non-empty fixme tag (the key in
any case, e.g. FIXME), newest first, each with its note, version, changeset,
timestamp, tags and a location: a node's own, or the middle of a way's nodes
(none for a relation). The OSM API can't search by tag, so, like the bbox and
adiff endpoints, this reads the workspace's tables directly. Anyone who can
open the workspace can call it.
Checked against a real Postgres with the OSM current_* tables: nodes, ways
and relations are found, empty notes and deleted elements aren't.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Implement workspace creation permissions based on TDEI roles (#147)
* Implement workspace creation permissions based on TDEI roles and update tests
* Implement TDEI dataset fetching and workspace creation validation based on dataset status and project group
* Implement workspace creation permission checks and related API endpoint
* Rename TDEI client variable for consistency in security and test files
* Add TDEI API backend URL and enhance dataset handling in workspace creation
- Introduced TDEI_API_BACKEND_URL in .env.example and docker-compose.local.yml for environment configuration.
- Added same_uuid function to compare UUIDs in a case-insensitive manner.
- Enhanced TdeiDataset class to include data_type and added matches_type method for workspace type validation.
- Updated fetch_tdei_dataset to handle dataset type and improved error handling for TDEI API responses.
- Modified WorkspaceRepository to enforce dataset type restrictions during workspace creation.
- Expanded integration and unit tests to cover new dataset type validations and TDEI API error scenarios.
* Document the workspace creation rule in CLAUDE.md
Who may create a workspace (POC, or the data generator of the matching
type), the extra checks when creating from a TDEI dataset, and that
tdei-admin gets no extra rights.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Normalize TDEI project group role names
Trim and lowercase the roles TDEI returns so "POC" or " poc " grant the
same rights as "poc", as the frontend's hasCreationRole already does.
Roles the backend doesn't model (e.g. tdei-admin) are dropped; they
granted nothing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Require TDEI_API_BACKEND_URL with no default
A dev default would quietly send prod tokens to api-dev.tdei.us when a
deployment doesn't set it. Fail at startup instead, including for the
empty string docker-compose passes when the variable is unset.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Jeff Maki <hello@jeffmaki.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Make GET /workspaces/mine smaller and cheaper (#158)
- Apply gig_only, which the ScoutRoute apps already send: only OSW
workspaces open to external apps. lat, lon and radius stay ignored on
purpose.
- Don't load the geometry column or join in the long-form quest and
imagery definitions; the list response sends none of them.
- Gzip responses from this service's own API (/api/v1/) for clients that
accept it. Proxied OSM traffic is left as received.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Make Sentry setup visible: startup log, release from the commit, /health version (#160)
* Say at startup whether errors reach Sentry
Without SENTRY_DSN the Sentry SDK silently sends nothing; the App
Services ran that way and nobody could tell. Log a warning when it's
missing, and the environment and release when it's set.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Bake the commit into the image as CODE_VERSION
Sentry's release (and the startup log line) read CODE_VERSION, which
nothing set, so every event reported release "unknown". The image
workflows now pass the commit SHA as a build arg; the Dockerfile sets it
last so a new commit doesn't invalidate the dependency layers.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Report the running commit from /health
/health now returns {"status": "ok", "version": <CODE_VERSION>}, so a
deploy can be confirmed from outside. "unknown" for an image built
without the build arg.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Leave tdeiMetadata and kartaViewToken out of GET /workspaces/mine (#163)
For a workspace created from a TDEI dataset, tdeiMetadata is the whole
dataset record, so it made the list large; the dashboard now fetches it
for the selected workspace from GET /workspaces/{id}. kartaViewToken was
sent to every member of the project group; no client reads it from the
list. The always-null longFormQuestDef and imageryListDef go too.
/mine now uses WorkspaceSummaryResponse; WorkspaceResponse extends it for
the single-workspace GET, which still sends all four. The list query no
longer loads tdeiMetadata.
Deploy after the frontend change that reads tdeiMetadata per workspace.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Naresh Kumar D <susrisha@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Rajesh Kantipudi <44539669+iamrajeshk@users.noreply.github.com>
jeffmaki
added a commit
that referenced
this pull request
Nov 2, 2026
* Update push-docker-image.yml
Pushes the workspaces-backend to the app service on push
* Update push-docker-image.yml
added other step for building the environment
* Update push-docker-image.yml
v3 deployment
* Update push-docker-image.yml
* Update push-docker-image.yml
name check
* Add GET /workspaces/{id}/fixmes for the review queue (#154)
Lists the workspace's current elements with a non-empty fixme tag (the key in
any case, e.g. FIXME), newest first, each with its note, version, changeset,
timestamp, tags and a location: a node's own, or the middle of a way's nodes
(none for a relation). The OSM API can't search by tag, so, like the bbox and
adiff endpoints, this reads the workspace's tables directly. Anyone who can
open the workspace can call it.
Checked against a real Postgres with the OSM current_* tables: nodes, ways
and relations are found, empty notes and deleted elements aren't.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Implement workspace creation permissions based on TDEI roles (#147)
* Implement workspace creation permissions based on TDEI roles and update tests
* Implement TDEI dataset fetching and workspace creation validation based on dataset status and project group
* Implement workspace creation permission checks and related API endpoint
* Rename TDEI client variable for consistency in security and test files
* Add TDEI API backend URL and enhance dataset handling in workspace creation
- Introduced TDEI_API_BACKEND_URL in .env.example and docker-compose.local.yml for environment configuration.
- Added same_uuid function to compare UUIDs in a case-insensitive manner.
- Enhanced TdeiDataset class to include data_type and added matches_type method for workspace type validation.
- Updated fetch_tdei_dataset to handle dataset type and improved error handling for TDEI API responses.
- Modified WorkspaceRepository to enforce dataset type restrictions during workspace creation.
- Expanded integration and unit tests to cover new dataset type validations and TDEI API error scenarios.
* Document the workspace creation rule in CLAUDE.md
Who may create a workspace (POC, or the data generator of the matching
type), the extra checks when creating from a TDEI dataset, and that
tdei-admin gets no extra rights.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Normalize TDEI project group role names
Trim and lowercase the roles TDEI returns so "POC" or " poc " grant the
same rights as "poc", as the frontend's hasCreationRole already does.
Roles the backend doesn't model (e.g. tdei-admin) are dropped; they
granted nothing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Require TDEI_API_BACKEND_URL with no default
A dev default would quietly send prod tokens to api-dev.tdei.us when a
deployment doesn't set it. Fail at startup instead, including for the
empty string docker-compose passes when the variable is unset.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Jeff Maki <hello@jeffmaki.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Make GET /workspaces/mine smaller and cheaper (#158)
- Apply gig_only, which the ScoutRoute apps already send: only OSW
workspaces open to external apps. lat, lon and radius stay ignored on
purpose.
- Don't load the geometry column or join in the long-form quest and
imagery definitions; the list response sends none of them.
- Gzip responses from this service's own API (/api/v1/) for clients that
accept it. Proxied OSM traffic is left as received.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Make Sentry setup visible: startup log, release from the commit, /health version (#160)
* Say at startup whether errors reach Sentry
Without SENTRY_DSN the Sentry SDK silently sends nothing; the App
Services ran that way and nobody could tell. Log a warning when it's
missing, and the environment and release when it's set.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Bake the commit into the image as CODE_VERSION
Sentry's release (and the startup log line) read CODE_VERSION, which
nothing set, so every event reported release "unknown". The image
workflows now pass the commit SHA as a build arg; the Dockerfile sets it
last so a new commit doesn't invalidate the dependency layers.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Report the running commit from /health
/health now returns {"status": "ok", "version": <CODE_VERSION>}, so a
deploy can be confirmed from outside. "unknown" for an image built
without the build arg.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Leave tdeiMetadata and kartaViewToken out of GET /workspaces/mine (#163)
For a workspace created from a TDEI dataset, tdeiMetadata is the whole
dataset record, so it made the list large; the dashboard now fetches it
for the selected workspace from GET /workspaces/{id}. kartaViewToken was
sent to every member of the project group; no client reads it from the
list. The always-null longFormQuestDef and imageryListDef go too.
/mine now uses WorkspaceSummaryResponse; WorkspaceResponse extends it for
the single-workspace GET, which still sends all four. The list query no
longer loads tdeiMetadata.
Deploy after the frontend change that reads tdeiMetadata per workspace.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Rename the /mine filter to external_only, keeping gig_only as a synonym (#165)
external_only is now the documented parameter. The mobile apps send
gig_only, so it keeps working but is left out of the OpenAPI schema. If
either is true, the filter applies.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Naresh Kumar D <susrisha@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Rajesh Kantipudi <44539669+iamrajeshk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #159, which merged into
mine-gig-only-filterrather thandevelop, so its change never reacheddevelopor any deployment. This is the same commit, cherry-picked onto currentdevelop.Important
Deploy order: workspaces-frontend#176 must be deployed before this reaches each environment. It's on
stagingalready, so this is safe for stage. For prod, #176 has to go first or in the same release; otherwise the dashboard map loses dataset areas and the info panel loses the dataset version.What changes:
/minenow returns a newWorkspaceSummaryResponse, which leaves out:tdeiMetadata: for a workspace created from a TDEI dataset, this holds the whole dataset record.kartaViewToken: it was sent to every member of the workspace's project group, and no client reads it from the list.longFormQuestDefandimageryListDef: alwaysnullin the list.WorkspaceResponseextends the summary, soGET /workspaces/{id}still sends all four fields.tdeiMetadatacolumn.Clients checked (source branches, as of #159):
tdeiMetadatafromGET /workspaces/{id}. It never readskartaViewToken.Testing:
./scripts/ci.shpasses on this branch. A new integration test checks that/mineitems lack all four fields whileGET /1still returns them.After merging: this needs a Develop to Stage PR. To confirm on stage, check that
/healthshows the new commit and that/openapi.jsonlistsWorkspaceSummaryResponsefor/api/v1/workspaces/mine.🤖 Generated with Claude Code