Repository navigation
feat(web): animate running SOP node activity - #178
Merged
crispinhu27 merged 2 commits intoNov 12, 2026
Merged
Conversation
Collaborator
|
LoopForge PR Review — head Verdict: ✅ Pass
|
Collaborator
|
LoopForge PR Review — head Verdict: ✅ Pass
No blocking issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The selected SOP node's inspector previously showed plain activity text, making it hard to tell whether work was still progressing. An executing node now shows a spinner beside its running status and a subtle left-to-right shimmer across its current activity text.
The animation follows the selected node and its child SOP's actual execution state. Completed nodes, human approval, pause and cancellation remain static. Streamed text updates retain the existing elements so the animation is not restarted by each log event. Light/dark themes, long activity text, reduced motion and forced colors are supported.
Scope
Compatibility
No API, workflow execution, schema, dependency or Runner protocol changes. This PR is based directly on upstream main and is independent of the Windows contribution in #172.
Validation
go test -p=2 ./... -count=1 -timeout=600sandgo vet ./...on Linux with Go 1.27.3 and the branch's prebuilt Gate helper.git diff --check.The initial browser checks used fixture rendering. The follow-up below also exercises a real local service and a synthetic script run, without model calls or changes to existing user runs. The entire deployed public browser suite and Classic/Portable checks were not run for this presentation-only change.
Review follow-up: stylesheet caching and live UI
The reported immutable-URL defect does not reproduce through the production HTML handler.
studioFileServerserves revalidated HTML and callsstampStudioIndex, which replaces handwritten CSS/JS queries with content hashes on every HTML request. The literal version inweb/index.htmlis not the URL delivered to a browser. No production caching or version-string changes are needed.Commit
8ae5221957b72660337c2541fa89c33fc6ee141badds regression coverage and fresh real-service screenshots with cache-upgrade acceptance details.?v=b5623289d4bd5745, then reused it from its HTTP cache on another normal document navigation (confirmed through CDP).?v=e10036f176cdcba1; the next normal navigation requested the new URL and displayed both animations. There was no cache clear, hard refresh or Playwright request routing.TestStudioIndexStampsAssetsWithContentHash,TestStudioStylesheetChangesInvalidateURLWithoutEditingIndex, andTestGinMiddlewareAndSmallViews. JavaScript syntax, public-content and whitespace checks passed.This is evidence for re-review; it does not claim a maintainer's UI acceptance.
Safety
Classic host bundles and third-party assets are unchanged.