Repository navigation
docs(readme): explain the benefits of cloud deployment - #200
Open
newexploreor wants to merge 3 commits into
Open
newexploreor wants to merge 3 commits into
newexploreor wants to merge 3 commits into
Conversation
Collaborator
|
LoopForge PR Review — head Conclusion: Pass ✅ Documentation-only change (+8/+8 lines in
No blocking issues. |
3 of 11 tasks
Yanami-2K
requested changes
Nov 14, 2026
Yanami-2K
left a comment
Collaborator
There was a problem hiding this comment.
内容本身没有问题,但和同一作者的 #163 互相冲突,需要只保留一个:
- 与 #163 修改同一段 本 PR 在
README.md和README.zh-CN.md的## Quick start/## 快速开始下、“Install Git and clone the repository first”那一行之前插入了“Why deploy to the cloud?”。#163 正好改了这一行(加了“Runs on macOS and Linux…”),还在后面新增了“Install on a cloud server”小节。两个 PR 会产生文本冲突,而且“为什么上云”和“怎么上云”分在两个 PR 里也不利于维护。建议保留 #163,把本 PR 的三条要点合并到 #163 的“Install on a cloud server”小节开头,然后关闭本 PR。 - 如果维护者更希望先合入本 PR:请先 rebase 到最新 main。本 PR 的 hunk 从第 67 行开始,而 #163 和 #172 基于的 main 里同一段已经从第 71 行开始,说明这个分支的基线较旧。另外,“See the deployment guide for HTTPS and runner setup”与 #163 新增的 HTTPS 折叠段重复,需要和 #163 协调,只保留一处入口。
Collaborator
|
LoopForge PR Review — head Verdict: ❌ Not pass — @newexploreor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add a cloud deployment section at the start of Quick start in both READMEs.
Scope
Validation
git diff --check origin/mainpython3 scripts/check-public.py